update commit checker to tolerate glide updates, clarify bump commit #20381
Conversation
openshift-ci-robot
added
the
approved
openshift-ci-robot
added
the
size/S
|
travis was failing on |
|
/assign @deads2k @juanvallejo |
tools/rebasehelpers/util/git.go
Outdated
| @@ -118,6 +118,8 @@ type File string | |||
| func (f File) HasVendoredCodeChanges() bool { | |||
| return strings.HasPrefix(string(f), "Godeps/_workspace") || | |||
| strings.HasPrefix(string(f), "vendor") || | |||
| strings.HasPrefix(string(f), "glide.lock") || | |||
| strings.HasPrefix(string(f), "glide.yaml") || | |||
There was a problem hiding this comment.
does this mean that I'd have to put glide.yaml changes into a bump commit?
There was a problem hiding this comment.
it didn't have that effect when I tested it, it just tolerated it in a bump commit, but now I'm not sure... I'll drop this... the other bits were more important
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
No description provided.