Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ROUTER_BIND_PORTS_BEFORE_SYNC configuration #20410

Closed

Conversation

ironcladlou
Copy link
Contributor

The ROUTER_BIND_PORTS_BEFORE_SYNC option was added and the liveness checks it
gates was enabled by default. We don't have any strong use case to support
making it configurable. Remove the option to reduce our configuration surface
area.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1603835.

/cc @openshift/sig-network-edge

The ROUTER_BIND_PORTS_BEFORE_SYNC option was added and the liveness checks it
gates was enabled by default. We don't have any strong use case to support
making it configurable. Remove the option to reduce our configuration surface
area.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1603835.
@Miciah
Copy link
Contributor

Miciah commented Jul 24, 2018

I think the conditional is broken but necessary. The intention is to omit the "backend" (HAProxy) check from the liveness checks if ROUTER_BIND_PORTS_AFTER_SYNC is enabled in order to prevent the liveness checks from failing during the period between when the router pod starts and when HAProxy starts responding to its liveness check (after sync). See #19009 (comment).

@ironcladlou
Copy link
Contributor Author

@Miciah is right, I got this wrong. New PR necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants