Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPSTREAM: 64971: Cherry pick of #64255: fix field removal in mutating admission webhooks #20502

Closed
wants to merge 1 commit into from

Conversation

pmorie
Copy link
Contributor

@pmorie pmorie commented Aug 1, 2018

Needed to make knative run smoothly on 3.10

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 1, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pmorie
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: sttts

If they are not already assigned, you can assign the PR to them by writing /assign @sttts in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pmorie
Copy link
Contributor Author

pmorie commented Aug 1, 2018

/retest

@pmorie pmorie force-pushed the cherry-pick-64971 branch from d5f0b3d to 6efefed Compare August 1, 2018 18:57
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 1, 2018

@pmorie: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/end_to_end 6efefed link /test end_to_end

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@smarterclayton
Copy link
Contributor

This cherrypick needs to be release-3.10 to go into origin.

@pmorie
Copy link
Contributor Author

pmorie commented Aug 2, 2018

Wrong branch

@pmorie
Copy link
Contributor Author

pmorie commented Aug 2, 2018

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants