Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move authorizer into the construction of the kubeapiserver #20552

Closed
wants to merge 2 commits into from
Closed

move authorizer into the construction of the kubeapiserver #20552

wants to merge 2 commits into from

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Aug 6, 2018

This builds a valid authorizer when constructing the kubeapiserver config.

/assign @sttts

On the path to creating a reasonable hypershift openshift-kube-apiserver command

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 6, 2018
@deads2k deads2k force-pushed the server-11-authorization branch from a2b5091 to 93e8b65 Compare August 6, 2018 20:33
@deads2k
Copy link
Contributor Author

deads2k commented Aug 7, 2018

/retest

enj
enj reviewed Aug 7, 2018
View reviewed changes
pkg/cmd/server/kubernetes/master/authorizer.go
)

func NewAuthorizer(internalInformers kinternalinformers.SharedInformerFactory, informers kinformers.SharedInformerFactory, projectRequestDenyMessage string) authorizer.Authorizer {
messageMaker := openshiftauthorizer.NewForbiddenMessageResolver(projectRequestDenyMessage)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deads2k can we merge #20379 first so this forbidden message maker can die before moving here?

That PR is just waiting on a LGTM from @smarterclayton

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deads2k can we merge #20379 first so this forbidden message maker can die before moving here?

That PR is just waiting on a LGTM from @smarterclayton

Get my comment fixed and I'll do it.

Continue review here please.

@deads2k
Copy link
Contributor Author

deads2k commented Aug 7, 2018

/retest

@enj
Copy link
Contributor

enj commented Aug 7, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 7, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, enj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link

@deads2k: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/end_to_end 2a89f64 link /test end_to_end
ci/openshift-jenkins/extended_clusterup 2a89f64 link /test extended_clusterup

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@deads2k
Copy link
Contributor Author

deads2k commented Aug 7, 2018

/hold

I may try a different route to get here.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 7, 2018
@openshift-bot
Copy link
Contributor

@deads2k: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot openshift-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 9, 2018
@deads2k deads2k closed this Aug 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enj enj enj left review comments

@csrwng csrwng Awaiting requested review from csrwng

@mrogers950 mrogers950 Awaiting requested review from mrogers950

Assignees

@sttts sttts

@enj enj

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@deads2k @enj @openshift-ci-robot @openshift-bot @sttts