spec: keep /etc/sysconfig/origin-node

[vrutkovs]

This env file should be preserved between major upgrades.
Currently update from 3.10 to 3.11 would erase it (leaving the backup in
.rpmsave)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1618420

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vrutkovs
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: liggitt

If they are not already assigned, you can assign the PR to them by writing /assign @liggitt in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@vrutkovs: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/openshift-jenkins/end_to_end	7f99afa	link	/test end_to_end
ci/openshift-jenkins/extended_conformance_install	7f99afa	link	/test extended_conformance_install
ci/openshift-jenkins/extended_clusterup	7f99afa	link	/test extended_clusterup
ci/prow/gcp	7f99afa	link	/test gcp

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[vrutkovs]

That's apparently a wrong way to fix it.

@smarterclayton @soltysh Where do the AWS creds for node need to be stored in 3.11?

[smarterclayton]

Ansible handles all this - this doesn't belong in origin anymore.

[smarterclayton]

/hold

[vrutkovs]

Ansible won't update this file, as it assumes Origin RPMs won't remove it.

There is openshift/openshift-ansible#9641 PR to fill in this file and move on, however:

• Custom adjustments in /etc/sysconfig/origin-node would be rewritten - are we okay with that?
• Online is not setting AWS creds in the inventory - and openshift-ansible requires these to be set, so the inventory would have to be changed (cc @jupierce)

[smarterclayton]

Well, openshift no longer cares about this file, so it's up to ansible now :)

…

On Fri, Aug 17, 2018 at 2:10 PM Vadim Rutkovsky ***@***.***> wrote: Ansible won't update this file, as it assumes Origin RPMs won't remove it. There is openshift/openshift-ansible#9641 <openshift/openshift-ansible#9641> PR to fill in this file and move on, however: - Custom adjustments in /etc/sysconfig/origin-node would be rewritten - are we okay with that? - Online is not setting AWS creds in the inventory - and openshift-ansible requires these to be set, so the inventory would have to be changed (cc @jupierce <https://github.com/jupierce>) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#20683 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABG_pyIdGnx0tw4XUxuXIZUfKJedRK1Iks5uRwcqgaJpZM4WBxUy> .

[sdodson]

Well, openshift no longer cares about this file, so it's up to ansible now :)

Can you elaborate on that? This is mostly just a quirk of RPM behavior whereby RPM feels the need to clean up files that have been removed, we're basically stuck with it. I'd like to see us try the following if we no longer want to distribute this file via the RPM. This, I think, will leave it in place during upgrade if it exists.

%ghost %config(noreplace) %{_sysconfdir}/sysconfig/%{name}-node

[vrutkovs]

Replaced by #20717