Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPSTREAM: <carry>: patch in a non-standard location for apiservices #20719

Closed
wants to merge 1 commit into from

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Aug 21, 2018

OpenShift has stored apiservices in a non-standard location. This codifies that into a patch since we have no need to support the old location.

@liggitt is there an easy way for me to look at this directly?

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 21, 2018
@deads2k deads2k mentioned this pull request Aug 21, 2018
13 tasks
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 21, 2018
@liggitt
Copy link
Contributor

liggitt commented Aug 21, 2018

@liggitt is there an easy way for me to look at this directly?

not sure what you mean

@liggitt
Copy link
Contributor

liggitt commented Aug 21, 2018

you mean viewing in etcd, like ETCDCTL_API=3 etcdctl get / --prefix --keys-only | grep apiservices?

@deads2k
Copy link
Contributor Author

deads2k commented Aug 21, 2018

thanks.

ETCDCTL_API=3 etcdctl get / --prefix --keys-only --cert=openshift.local.clusterup/kube-apiserver/master.etcd-client.crt --key=openshift.local.clusterup/kube-apiserver/master.etcd-client.key --cacert=openshift.local.clusterup/kube-apiserver/etcd.server.crt --endpoints=127.0.0.1:4001 | grep apiservices

/hold

holding until I test it in cluster up

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 21, 2018
@deads2k deads2k force-pushed the server-18-location branch from cc1c4eb to 8d7e786 Compare August 21, 2018 20:55
@deads2k
Copy link
Contributor Author

deads2k commented Aug 21, 2018

/hold cancel

confirmed in my kubeapiserver branch

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 21, 2018
@deads2k deads2k closed this Aug 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants