Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPSTREAM: 68008: apiserver: forward panic in WithTimeout filter #20848

Merged
merged 1 commit into from
Sep 14, 2018

Conversation

sttts
Copy link
Contributor

@sttts sttts commented Sep 4, 2018

Cherry pick of kubernetes/kubernetes#68001 onto master.

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 4, 2018
@deads2k
Copy link
Contributor

deads2k commented Sep 4, 2018

@sttts did you accidentally pick the wrong thing?

@sttts
Copy link
Contributor Author

sttts commented Sep 5, 2018

did you accidentally pick the wrong thing?

Didn't have the latest master with the cherry-pick script fix yet.

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 5, 2018
@sttts
Copy link
Contributor Author

sttts commented Sep 6, 2018

@deads2k @mfojtik fixes there cherry-pick. ptal.

@sttts
Copy link
Contributor Author

sttts commented Sep 7, 2018

@mfojtik lgtm?

@deads2k
Copy link
Contributor

deads2k commented Sep 13, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 13, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deads2k
Copy link
Contributor

deads2k commented Sep 13, 2018

/cherrypick release-3.11

@openshift-cherrypick-robot

@deads2k: once the present PR merges, I will cherry-pick it on top of release-3.11 in a new PR and assign it to you.

In response to this:

/cherrypick release-3.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 8d6f6f3 into openshift:master Sep 14, 2018
@openshift-cherrypick-robot

@deads2k: new pull request created: #20979

In response to this:

/cherrypick release-3.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants