Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hack: add kubectl to release tars and zip #20890

Merged

Conversation

mfojtik
Copy link
Contributor

@mfojtik mfojtik commented Sep 7, 2018

This should be enough to include the kubectl binary along side with the oc binary.

/cc @smarterclayton

@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 7, 2018
@mfojtik
Copy link
Contributor Author

mfojtik commented Sep 7, 2018

/cc @derekwaynecarr
/cc @mpbarrett

@brenton
Copy link
Contributor

brenton commented Sep 7, 2018

@mfojtik, could up date the spec file as part of this PR too? https://github.com/openshift/origin/blob/master/origin.spec#L425

@mfojtik mfojtik force-pushed the hack-01-add-kubectl branch from 8304f88 to b6d62dc Compare September 7, 2018 13:18
@mfojtik
Copy link
Contributor Author

mfojtik commented Sep 7, 2018

@brenton done

@mfojtik
Copy link
Contributor Author

mfojtik commented Sep 7, 2018

/cherrypick release-3.11

@openshift-cherrypick-robot

@mfojtik: once the present PR merges, I will cherry-pick it on top of release-3.11 in a new PR and assign it to you.

In response to this:

/cherrypick release-3.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@derekwaynecarr
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 7, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, mfojtik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [derekwaynecarr,mfojtik]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deads2k
Copy link
Contributor

deads2k commented Sep 7, 2018

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 7, 2018
@deads2k
Copy link
Contributor

deads2k commented Sep 7, 2018

/hold cancel

my pull failed twice on networking.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 7, 2018
@openshift-merge-robot openshift-merge-robot merged commit d780b65 into openshift:master Sep 7, 2018
@openshift-cherrypick-robot

@mfojtik: new pull request created: #20900

In response to this:

/cherrypick release-3.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants