install kubectl along with oc in rpm spec #20918
Conversation
openshift-ci-robot
added
size/XS
origin.spec
Outdated
| @@ -299,7 +299,7 @@ for cmd in \ | |||
| openshift-router \ | |||
| kubectl | |||
| do | |||
| ln -s oc %{buildroot}%{_bindir}/$cmd | |||
| ln -f -s oc %{buildroot}%{_bindir}/$cmd | |||
There was a problem hiding this comment.
This is creating a link in %{_bindir} == /usr/bin
The e-mail complain I see is about this line failing:
%{_datadir}/%{name}/linux/kubectl
where %{_datadir} == /usr/share
What is creating those files in `%{buildroot}%{_datadir} ?
There was a problem hiding this comment.
Did you mean to include the right kubectl files back up about lines 278-280?
There was a problem hiding this comment.
i believe they are created by make build (line 227), you are right, I have to add them along with 'oc' in 278. Updated.
mfojtik
force-pushed
the
hack-03-fix-symlink
branch
from
f30d1ea to
e59af1b
Compare
mfojtik
changed the title
mfojtik
force-pushed
the
hack-03-fix-symlink
branch
from
e59af1b to
926262d
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eparis, mfojtik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/cherrypick release-3.11 |
|
@mfojtik: new pull request created: #20932 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No description provided.