Restore graceful shutdown of DNS server

[Miciah]

Restore signal handling and graceful shutdown of DNS that had been added in c802e22 but was subsequently lost during rebase in 564ee03.

Graceful shutdown is necessary to ensure that when OpenShift's DNS server shuts down, we remove it from the dnsmasq configuration.

This commit fixes bug 1624448.

https://bugzilla.redhat.com/show_bug.cgi?id=1624448

@knobunc @ironcladlou @sdodson @smarterclayton

[Miciah]

/retest

Looks like a flake:

+ ssh -F /var/lib/jenkins/jobs/test_pull_request_origin_extended_conformance_install/workspace/.config/origin-ci-tool/inventory/.ssh_config openshiftdevel sudo chmod o+rw /etc/environment
++ export status=FAILURE
++ status=FAILURE
+ set +o xtrace
########## FINISHED STAGE: FAILURE: FORWARD PARAMETERS TO THE REMOTE HOST [00h 00m 00s] ##########

[Miciah]

/retest

[smarterclayton]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miciah, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/cmd/OWNERS [smarterclayton]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[smarterclayton]

/cherrypick release-3.11

[openshift-cherrypick-robot]

@smarterclayton: once the present PR merges, I will cherry-pick it on top of release-3.11 in a new PR and assign it to you.

In response to this:

/cherrypick release-3.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-cherrypick-robot]

@smarterclayton: #21009 failed to apply on top of branch "release-3.11":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
A	pkg/cmd/server/start/network/start_network.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/cmd/server/start/start_network.go
CONFLICT (content): Merge conflict in pkg/cmd/server/start/start_network.go
Patch failed at 0001 Restore graceful shutdown of DNS server

In response to this:

/cherrypick release-3.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Miciah]

@smarterclayton, cherry picking failed because 2924ec1, which renames pkg/cmd/server/start/start_network.go to pkg/cmd/server/start/network/start_network.go, is in master but not in release-3.11. We don't want that commit in release-3.11, right?

[smarterclayton]

Correct. On Sep 18, 2018, at 6:21 PM, Miciah Dashiel Butler Masters < [email protected]> wrote: @smarterclayton <https://github.com/smarterclayton>, cherry picking failed because 2924ec1 <2924ec1>, which renames pkg/cmd/server/start/start_network.go to pkg/cmd/server/start/network/start_network.go, is in master but not in release-3.11. We don't want that commit in release-3.11, right? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#21009 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABG_p5BNalNwiCnUD-cpG36kv3SKqf3Gks5ucR2JgaJpZM4Ws9X2> .