-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate: ignore resources that cannot be listed and updated #21071
migrate: ignore resources that cannot be listed and updated #21071
Conversation
This change updates FindAllCanonicalResources to check the verbs asserted by discovery for listing and updating capability. This prevents us from trying to update aggregated resources such as pod metrics. Bug 1631517 Signed-off-by: Monis Khan <[email protected]>
/cherrypick release-3.11 |
@enj: once the present PR merges, I will cherry-pick it on top of release-3.11 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick release-3.10 |
@enj: once the present PR merges, I will cherry-pick it on top of release-3.10 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick release-3.9 |
@enj: once the present PR merges, I will cherry-pick it on top of release-3.9 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, enj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@enj: #21071 failed to apply on top of branch "release-3.9":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@enj: new pull request created: #21075 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@enj: #21071 failed to apply on top of branch "release-3.10":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This change updates
FindAllCanonicalResources
to check the verbs asserted by discovery for listing and updating capability. This prevents us from trying to update aggregated resources such as pod metrics.Bug 1631517
Signed-off-by: Monis Khan [email protected]
/kind bug
/assign @deads2k
/cc @jupierce