Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Reapply "OCPBUGS-18865: Reapply "Merge pull request #28944 from vrutkovs/in-cluster-fixes-v4""" #29278

Merged

Conversation

neisw
Copy link
Contributor

@neisw neisw commented Nov 11, 2024

Reverts #29058

4.18.0-0.nightly-2024-11-10-205924 has overall-analysis failure related to techpreview-serial failures (excludes aws). 2 of the failures azure and gcp are kube-api-http1/2 endpoint related.

Staging now, will hold for review.

/payload-job periodic-ci-openshift-release-master-ci-4.18-e2e-azure-ovn-techpreview-serial
/payload-job periodic-ci-openshift-release-master-ci-4.18-e2e-gcp-ovn-techpreview-serial

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 11, 2024
@openshift-ci-robot
Copy link

@neisw: This pull request references Jira Issue OCPBUGS-18865, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Reverts #29058

4.18.0-0.nightly-2024-11-10-205924 has overall-analysis failure related to techpreview-serial failures (excludes aws). 2 of the failures azure and gcp are kube-api-http1/2 endpoint related.

Staging now, will hold for review.

/payload-job periodic-ci-openshift-release-master-ci-4.18-e2e-azure-ovn-techpreview-serial
/payload-job periodic-ci-openshift-release-master-ci-4.18-e2e-gcp-ovn-techpreview-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Nov 11, 2024
@openshift-ci openshift-ci bot requested review from p0lyn0mial and sdodson November 11, 2024 02:02
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 11, 2024
@neisw
Copy link
Contributor Author

neisw commented Nov 11, 2024

/hold
/assign @vrutkovs

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 11, 2024
@neisw
Copy link
Contributor Author

neisw commented Nov 11, 2024

/payload-job periodic-ci-openshift-release-master-ci-4.18-e2e-azure-ovn-techpreview-serial periodic-ci-openshift-release-master-ci-4.18-e2e-gcp-ovn-techpreview-serial

Copy link
Contributor

openshift-ci bot commented Nov 11, 2024

@neisw: trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.18-e2e-azure-ovn-techpreview-serial
  • periodic-ci-openshift-release-master-ci-4.18-e2e-gcp-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/6c182e40-9fd1-11ef-8a4d-5b3e2df4ee43-0

@vrutkovs
Copy link
Member

/hold cancel
/lgtm

Seems there is an OVN bug for gcp/azure (it even crashes in payload-job rehearsal)

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Nov 11, 2024
Copy link
Contributor

openshift-ci bot commented Nov 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neisw, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 80b1c6e into openshift:master Nov 11, 2024
24 of 27 checks passed
@openshift-ci-robot
Copy link

@neisw: Jira Issue OCPBUGS-18865: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-18865 has not been moved to the MODIFIED state.

In response to this:

Reverts #29058

4.18.0-0.nightly-2024-11-10-205924 has overall-analysis failure related to techpreview-serial failures (excludes aws). 2 of the failures azure and gcp are kube-api-http1/2 endpoint related.

Staging now, will hold for review.

/payload-job periodic-ci-openshift-release-master-ci-4.18-e2e-azure-ovn-techpreview-serial
/payload-job periodic-ci-openshift-release-master-ci-4.18-e2e-gcp-ovn-techpreview-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@neisw
Copy link
Contributor Author

neisw commented Nov 11, 2024

Thanks @vrutkovs. I saw those failures in the payload-job runs covering azure ovn minor upgrade but seemed like sippy showed them outside this PR as well so I didn't hold it but thanks for recognizing it.

We should be able to verify with /payload-aggregate periodic-ci-openshift-release-master-ci-4.18-upgrade-from-stable-4.17-e2e-azure-ovn-upgrade 10

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-tests
This PR has been included in build openshift-enterprise-tests-container-v4.19.0-202411111038.p0.g80b1c6e.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-tests
This PR has been included in build openshift-enterprise-tests-container-v4.18.0-202411111039.p0.g80b1c6e.assembly.stream.el9.
All builds following this will include this PR.

@vrutkovs
Copy link
Member

vrutkovs commented Dec 3, 2024

Re-apply: #29282

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants