Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.15] OCPBUGS-48749: Add team members to the OWNERS file for PR approvals #29465

Open
wants to merge 1 commit into
base: release-4.15
Choose a base branch
from
Open

[release-4.15] OCPBUGS-48749: Add team members to the OWNERS file for PR approvals #29465

wants to merge 1 commit into from

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #29443

/assign openshift-cherrypick-robot

/cherrypick release-4.14 release-4.13 release-4.12

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 22, 2025
Merged
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-48448 has been cloned as Jira Issue OCPBUGS-48749. Will retitle bug to link to clone.
/retitle [release-4.15] OCPBUGS-48749: Add team members to the OWNERS file for PR approvals

In response to this:

This is an automated cherry-pick of #29443

/assign openshift-cherrypick-robot

/cherrypick release-4.14 release-4.13 release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.15] OCPBUGS-48448: Add team members to the OWNERS file for PR approvals [release-4.15] OCPBUGS-48749: Add team members to the OWNERS file for PR approvals Jan 22, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 22, 2025
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-48749, which is invalid:

  • expected dependent Jira Issue OCPBUGS-48448 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #29443

/assign openshift-cherrypick-robot

/cherrypick release-4.14 release-4.13 release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Moebasim
Copy link

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jan 23, 2025
@openshift-ci-robot
Copy link

@Moebasim: This pull request references Jira Issue OCPBUGS-48749, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.z) matches configured target version for branch (4.15.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-48448 is in the state Release Pending (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-48448 targets the "4.16.z" version, which is one of the valid target versions: 4.16.0, 4.16.z
  • bug has dependents

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jan 23, 2025
@Moebasim
Copy link

/retest

1 similar comment
@Moebasim
Copy link

/retest

@Moebasim
Copy link

/retest-required

@Moebasim
Copy link

/retest

@sayan-biswas
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 4, 2025
@prabhapa
Copy link

prabhapa commented Feb 4, 2025

Hi @adambkaplan can you please approve this.

@hector-vido
Copy link

/retest

@prabhapa
Copy link

prabhapa commented Feb 5, 2025 •
edited
Loading

HI @coreydaley can you please approve this? The test errors are know and unrelated as this is just OWNERs change.

@sayan-biswas
Copy link

/override e2e-aws-etcd-recovery
/override e2e-aws-ovn-single-node-serial
/override e2e-aws-ovn-single-node-upgrade
/override e2e-gcp-ovn-builds

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 6, 2025

@sayan-biswas: sayan-biswas unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight openshift-staff-engineers.

In response to this:

/override e2e-aws-etcd-recovery
/override e2e-aws-ovn-single-node-serial
/override e2e-aws-ovn-single-node-upgrade
/override e2e-gcp-ovn-builds

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

adambkaplan
adambkaplan approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

/lgtm

@adambkaplan
Copy link
Contributor

/retest

@prabhapa
Copy link

prabhapa commented Feb 7, 2025

/label backport-risk-assessed
/label cherry-pick-approved

@openshift-ci openshift-ci bot added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Feb 7, 2025
@Moebasim
Copy link

Moebasim commented Feb 7, 2025

/approve

@de1987
Copy link

de1987 commented Feb 7, 2025

/cherrypick 9e6c3e1

@openshift-cherrypick-robot
Copy link
Author

@de1987: once the present PR merges, I will cherry-pick it on top of 9e6c3e11068bee54471dcd907d3aea346f2e7b74 in a new PR and assign it to you.

In response to this:

/cherrypick 9e6c3e1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Moebasim
Copy link

/cherrypick 9e6c3e1

@openshift-cherrypick-robot
Copy link
Author

@Moebasim: once the present PR merges, I will cherry-pick it on top of https://github.com/openshift/origin/commit/9e6c3e11068bee54471dcd907d3aea346f2e7b74 in a new PR and assign it to you.

In response to this:

/cherrypick 9e6c3e1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@xueqzhan
Copy link
Contributor

/lgtm

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, Moebasim, openshift-cherrypick-robot, sayan-biswas, xueqzhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 11, 2025
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 1ec9664 and 2 for PR HEAD 0360f1c in total

2 similar comments
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 1ec9664 and 2 for PR HEAD 0360f1c in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 1ec9664 and 2 for PR HEAD 0360f1c in total

@Moebasim
Copy link

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 12, 2025
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 1ec9664 and 2 for PR HEAD 0360f1c in total

@Moebasim
Copy link

/retest

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 17, 2025

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-ovn-builds 0360f1c link true /test e2e-gcp-ovn-builds
ci/prow/e2e-aws-etcd-recovery 0360f1c link false /test e2e-aws-etcd-recovery
ci/prow/e2e-aws-ovn-single-node-serial 0360f1c link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-aws-ovn-single-node-upgrade 0360f1c link false /test e2e-aws-ovn-single-node-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@prabhapa
Copy link

closing this as a new PR with additional changes is created for the same #29551

@openshift-cherrypick-robot
Copy link
Author

@prabhapa: once the present PR merges, I will cherry-pick it on top of cancel in a new PR and assign it to you.

In response to this:

/cherrypick cancel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@prabhapa
Copy link

/hold

@openshift-ci-robot openshift-ci-robot mentioned this pull request Feb 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adambkaplan adambkaplan adambkaplan approved these changes

@coreydaley coreydaley Awaiting requested review from coreydaley

@divyansh42 divyansh42 Awaiting requested review from divyansh42

Assignees

@dgoodwin dgoodwin

@adambkaplan adambkaplan

@sayan-biswas sayan-biswas

@kasturinarra kasturinarra

@Moebasim Moebasim

@openshift-cherrypick-robot openshift-cherrypick-robot

@jadhaj jadhaj

@pamoedom pamoedom

@gangwgr gangwgr

@prabhapa prabhapa

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.