Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-49600: Display etcd bootstrap event on timeline #29490

Merged
merged 2 commits into from
Feb 18, 2025
Merged

OCPBUGS-49600: Display etcd bootstrap event on timeline #29490

merged 2 commits into from
Feb 18, 2025

Conversation

vrutkovs
Copy link
Member

@vrutkovs vrutkovs commented Jan 28, 2025 •
edited
Loading

Update operator_log_scraper.go to record start/finish of etcd bootstrap member removal. This also updates other events tracked there to have a duration of 1 sec otherwise these are not being displayed on spyglass interval chart

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 28, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 28, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@vrutkovs
Copy link
Member Author

/test e2e-agnostic-ovn

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 28, 2025

@vrutkovs: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test e2e-aws-jenkins

/test e2e-aws-ovn-edge-zones

/test e2e-aws-ovn-fips

/test e2e-aws-ovn-image-registry

/test e2e-aws-ovn-microshift

/test e2e-aws-ovn-microshift-serial

/test e2e-aws-ovn-serial

/test e2e-gcp-ovn

/test e2e-gcp-ovn-builds

/test e2e-gcp-ovn-image-ecosystem

/test e2e-gcp-ovn-upgrade

/test e2e-metal-ipi-ovn-ipv6

/test images

/test lint

/test unit

/test verify

/test verify-deps

The following commands are available to trigger optional jobs:

/test 4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback

/test e2e-agnostic-ovn-cmd

/test e2e-aws

/test e2e-aws-csi

/test e2e-aws-disruptive

/test e2e-aws-etcd-certrotation

/test e2e-aws-etcd-recovery

/test e2e-aws-ovn

/test e2e-aws-ovn-cgroupsv2

/test e2e-aws-ovn-etcd-scaling

/test e2e-aws-ovn-ipsec-serial

/test e2e-aws-ovn-kube-apiserver-rollout

/test e2e-aws-ovn-kubevirt

/test e2e-aws-ovn-single-node

/test e2e-aws-ovn-single-node-serial

/test e2e-aws-ovn-single-node-techpreview

/test e2e-aws-ovn-single-node-techpreview-serial

/test e2e-aws-ovn-single-node-upgrade

/test e2e-aws-ovn-upgrade

/test e2e-aws-ovn-upgrade-rollback

/test e2e-aws-ovn-upi

/test e2e-aws-ovn-virt-techpreview

/test e2e-aws-proxy

/test e2e-azure

/test e2e-azure-ovn-etcd-scaling

/test e2e-azure-ovn-upgrade

/test e2e-baremetalds-kubevirt

/test e2e-external-aws

/test e2e-external-aws-ccm

/test e2e-external-vsphere-ccm

/test e2e-gcp-csi

/test e2e-gcp-disruptive

/test e2e-gcp-fips-serial

/test e2e-gcp-ovn-etcd-scaling

/test e2e-gcp-ovn-rt-upgrade

/test e2e-gcp-ovn-techpreview

/test e2e-gcp-ovn-techpreview-serial

/test e2e-hypershift-conformance

/test e2e-metal-ipi-ovn

/test e2e-metal-ipi-ovn-dualstack

/test e2e-metal-ipi-ovn-dualstack-local-gateway

/test e2e-metal-ipi-ovn-kube-apiserver-rollout

/test e2e-metal-ipi-serial

/test e2e-metal-ipi-serial-ovn-ipv6

/test e2e-metal-ipi-virtualmedia

/test e2e-metal-ovn-single-node-live-iso

/test e2e-metal-ovn-single-node-with-worker-live-iso

/test e2e-openstack-ovn

/test e2e-openstack-serial

/test e2e-vsphere

/test e2e-vsphere-ovn-dualstack-primaryv6

/test e2e-vsphere-ovn-etcd-scaling

/test okd-e2e-gcp

/test okd-scos-e2e-aws-ovn

/test okd-scos-images

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-origin-master-e2e-agnostic-ovn-cmd

pull-ci-openshift-origin-master-e2e-aws-csi

pull-ci-openshift-origin-master-e2e-aws-ovn-cgroupsv2

pull-ci-openshift-origin-master-e2e-aws-ovn-edge-zones

pull-ci-openshift-origin-master-e2e-aws-ovn-fips

pull-ci-openshift-origin-master-e2e-aws-ovn-kube-apiserver-rollout

pull-ci-openshift-origin-master-e2e-aws-ovn-microshift

pull-ci-openshift-origin-master-e2e-aws-ovn-microshift-serial

pull-ci-openshift-origin-master-e2e-aws-ovn-serial

pull-ci-openshift-origin-master-e2e-aws-ovn-single-node

pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-serial

pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade

pull-ci-openshift-origin-master-e2e-aws-ovn-upgrade

pull-ci-openshift-origin-master-e2e-gcp-csi

pull-ci-openshift-origin-master-e2e-gcp-ovn

pull-ci-openshift-origin-master-e2e-gcp-ovn-rt-upgrade

pull-ci-openshift-origin-master-e2e-gcp-ovn-upgrade

pull-ci-openshift-origin-master-e2e-hypershift-conformance

pull-ci-openshift-origin-master-e2e-metal-ipi-ovn

pull-ci-openshift-origin-master-e2e-metal-ipi-ovn-ipv6

pull-ci-openshift-origin-master-e2e-metal-ipi-ovn-kube-apiserver-rollout

pull-ci-openshift-origin-master-e2e-openstack-ovn

pull-ci-openshift-origin-master-images

pull-ci-openshift-origin-master-lint

pull-ci-openshift-origin-master-okd-scos-e2e-aws-ovn

pull-ci-openshift-origin-master-unit

pull-ci-openshift-origin-master-verify

pull-ci-openshift-origin-master-verify-deps

In response to this:

/test e2e-agnostic-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@vrutkovs
Copy link
Member Author

/test e2e-aws-ovn

@vrutkovs
Copy link
Member Author

/test e2e-azure e2e-gcp-ovn

@vrutkovs
Copy link
Member Author

/test e2e-azure e2e-gcp-ovn

@vrutkovs
Copy link
Member Author

/test e2e-azure e2e-gcp-ovn

1 similar comment
@vrutkovs
Copy link
Member Author

/test e2e-azure e2e-gcp-ovn

@vrutkovs vrutkovs marked this pull request as ready for review January 29, 2025 13:52
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 29, 2025
@openshift-ci openshift-ci bot requested review from deads2k and sjenning January 29, 2025 13:53
@vrutkovs vrutkovs changed the title Debug etcd monitor OCPBUGS-49600: Display etcd bootstrap event on timeline Jan 29, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 29, 2025
@openshift-ci-robot
Copy link

@vrutkovs: This pull request references Jira Issue OCPBUGS-49600, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jan 29, 2025
@vrutkovs
Copy link
Member Author

/cherry-pick release-4.18

@openshift-cherrypick-robot
Copy link

@vrutkovs: once the present PR merges, I will cherry-pick it on top of release-4.18 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link

@vrutkovs: This pull request references Jira Issue OCPBUGS-49600, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

Update operator_log_scraper.go to record start/finish of etcd bootstrap member removal. This also updates other events tracked there to have a duration of 1 sec otherwise these are not being displayed on spyglass interval chart

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-trt openshift-trt
Copy link

openshift-trt bot commented Feb 6, 2025

Job Failure Risk Analysis for sha: a729dbe

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-gcp-ovn-rt-upgrade IncompleteTests
Tests for this run (2) are below the historical average (1648): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-aws-ovn-cgroupsv2 IncompleteTests
Tests for this run (2) are below the historical average (2938): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

@vrutkovs
Copy link
Member Author

vrutkovs commented Feb 6, 2025

/retest

@Elbehery
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 13, 2025
@dgoodwin
Copy link
Contributor

Could you please also add the display flag with Display() if they're intended for chart display, the new UI will automatically show those.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 18, 2025
@dgoodwin
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 18, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgoodwin, Elbehery, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 18, 2025
@vrutkovs
Copy link
Member Author

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Feb 18, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 0b05d5f into openshift:master Feb 18, 2025
27 of 31 checks passed
@openshift-ci-robot
Copy link

@vrutkovs: Jira Issue OCPBUGS-49600: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-49600 has been moved to the MODIFIED state.

In response to this:

Update operator_log_scraper.go to record start/finish of etcd bootstrap member removal. This also updates other events tracked there to have a duration of 1 sec otherwise these are not being displayed on spyglass interval chart

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 18, 2025

@vrutkovs: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn 143c55b link false /test e2e-aws-ovn
ci/prow/e2e-gcp-csi 10d2178 link false /test e2e-gcp-csi
ci/prow/e2e-agnostic-ovn-cmd 10d2178 link false /test e2e-agnostic-ovn-cmd
ci/prow/e2e-aws-ovn-kube-apiserver-rollout 10d2178 link false /test e2e-aws-ovn-kube-apiserver-rollout

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-cherrypick-robot
Copy link

@vrutkovs: new pull request created: #29553

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 18, 2025
Open
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-tests
This PR has been included in build openshift-enterprise-tests-container-v4.19.0-202502182109.p0.g0b05d5f.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@dgoodwin dgoodwin

@Elbehery Elbehery

Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vrutkovs @openshift-ci-robot @openshift-cherrypick-robot @Elbehery @dgoodwin @openshift-bot