Wait for the UDN namespaces to have SA's created #29522
Conversation
|
/payload-aggregate periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn-techpreview 10 |
|
@tssurya: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/2e0ae590-e228-11ef-905e-e1dff8a8dba4-0 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: maiqueb, tssurya The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test e2e-gcp-ovn-techpreview |
|
/payload-job periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn-techpreview |
|
@tssurya: trigger 4 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/2acb7c90-e229-11ef-824f-b8ee96cdc719-0 |
ack yea I wasn't sure if that was not done intentionally or not... let me update the PR to use f.CreateNamespace |
I have fixed this now gonna repush given https://prow.ci.openshift.org/view/gs/test-platform-results/logs/openshift-origin-29522-nightly-4.19-e2e-vsphere-ovn-techpreview/1886389139251662848 passed with 0 UDN flakes |
tssurya
force-pushed
the
wait-for-SA-creation-in-UDN-namespaces
branch
from
a3f4d4d to
c07df86
Compare
|
New changes are detected. LGTM label has been removed. |
Should fix:
pods "red-pod-0" is forbidden: error looking up service account e2e-network-segmentation-e2e-6878-red/default: serviceaccount "default" not found
{
ErrStatus:
code: 403
details:
kind: pods
name: red-pod-0
message: 'pods "red-pod-0" is forbidden: error looking up service account e2e-network-segmentation-e2e-6878-red/default:
serviceaccount "default" not found'
metadata: {}
reason: Forbidden
status: Failure,
Also change the vanilla create namespaces calls
done in the tests to use the framework create
Signed-off-by: Surya Seetharaman <[email protected]>
tssurya
force-pushed
the
wait-for-SA-creation-in-UDN-namespaces
branch
from
c07df86 to
1af2b25
Compare
|
/test e2e-gcp-ovn-techpreview |
|
/payload-job periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn-techpreview |
|
@tssurya: trigger 4 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/4ce76410-e23d-11ef-8090-74b7cfcc80b1-0 |
| Name: defaultNetNamespace, | ||
| }, | ||
| }, metav1.CreateOptions{}) | ||
| _, err = f.CreateNamespace(context.TODO(), defaultNetNamespace, nil) |
There was a problem hiding this comment.
question @tssurya: don't we need to err = udnWaitForOpenShift(oc, namespace) here ?
There was a problem hiding this comment.
because that namespaces isn't a UDN namespace... unsure if that udnWaitForOCP is doing generic things or not.
but on a high level - it does make to add this wait also for the non UDN namespaces huh? i had thought of adding it for the default namespaces as well.. maybe we should like you are saying
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
@tssurya: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Job Failure Risk Analysis for sha: 1af2b25
|
Should fix: https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn-techpreview/1885825937673555968
@trozet already fixed something similar for SNO in 20a6022 from what I can tell we missed a few spots for the custom namespaces we create ourselves outside the test framework...