Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRT-2010: Exempt all SRE alerts from alert rules #29555

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −3
Open

TRT-2010: Exempt all SRE alerts from alert rules #29555

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions test/extended/prometheus/prometheus.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@ var _ = g.Describe("[sig-instrumentation][Late] OpenShift alerting rules [apigro

g.It("should have a valid severity label", func() {
err := helper.ForEachAlertingRule(alertingRules, func(alert promv1.AlertingRule) sets.String {
if alertsMissingValidSeverityLevel.Has(alert.Name) {
if alertsMissingValidSeverityLevel.Has(alert.Name) || strings.HasSuffix(alert.Name, "SRE") {
framework.Logf("Alerting rule %q is known to have invalid severity", alert.Name)
return nil
}
Expand Down Expand Up @@ -289,7 +289,7 @@ var _ = g.Describe("[sig-instrumentation][Late] OpenShift alerting rules [apigro

g.It("should have description and summary annotations", func() {
err := helper.ForEachAlertingRule(alertingRules, func(alert promv1.AlertingRule) sets.String {
if alertsMissingValidSummaryOrDescription.Has(alert.Name) {
if alertsMissingValidSummaryOrDescription.Has(alert.Name) || strings.HasSuffix(alert.Name, "SRE") {
framework.Logf("Alerting rule %q is known to have invalid summary or description", alert.Name)
return nil
}
Expand Down Expand Up @@ -319,7 +319,7 @@ var _ = g.Describe("[sig-instrumentation][Late] OpenShift alerting rules [apigro

g.It("should have a runbook_url annotation if the alert is critical", func() {
err := helper.ForEachAlertingRule(alertingRules, func(alert promv1.AlertingRule) sets.String {
if criticalAlertsMissingRunbookURLExceptions.Has(alert.Name) {
if criticalAlertsMissingRunbookURLExceptions.Has(alert.Name) || strings.HasSuffix(alert.Name, "SRE") {
framework.Logf("Critical alerting rule %q is known to have missing runbook_url.", alert.Name)
return nil
}
Expand Down