Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding extension binary to local path #29557

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stbenjam
Copy link
Member

This makes it easier to do local development.

This makes it easier to do local development.
@openshift-ci openshift-ci bot requested review from deads2k and p0lyn0mial February 20, 2025 16:35
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2025
@smg247
Copy link
Member

smg247 commented Feb 20, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 20, 2025
Copy link
Contributor

openshift-ci bot commented Feb 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smg247, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Feb 20, 2025

@stbenjam: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-ovn-upi 8285ecf link true /test e2e-vsphere-ovn-upi
ci/prow/e2e-metal-ipi-ovn 8285ecf link false /test e2e-metal-ipi-ovn
ci/prow/e2e-metal-ipi-ovn-kube-apiserver-rollout 8285ecf link false /test e2e-metal-ipi-ovn-kube-apiserver-rollout
ci/prow/e2e-hypershift-conformance 8285ecf link false /test e2e-hypershift-conformance
ci/prow/e2e-aws-ovn-single-node-upgrade 8285ecf link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-openstack-ovn 8285ecf link false /test e2e-openstack-ovn
ci/prow/okd-scos-e2e-aws-ovn 8285ecf link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-ovn-kube-apiserver-rollout 8285ecf link false /test e2e-aws-ovn-kube-apiserver-rollout

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants