Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log bugs #5499

Closed
wants to merge 1 commit into from
Closed

Log bugs #5499

wants to merge 1 commit into from

Conversation

benjaminapetersen
Copy link
Contributor

  • Fix chromeless logs loading err due to requiring user action (tab click) to init logs
  • Fix 1275908 (bugzilla): download raw link updated to use download icon
  • Fix bug 5469 (github), href missing on reconnect link

@jwforres @spadgett

@benjaminapetersen
Bugs:
ee34b73 
- Fix chromeless logs loading err due to requiring user action (tab click) to init logs
- bug 1275908 (bugzilla): download raw link updated to use download icon
- Fix bug 5469, href missing on reconnect link
jwforres
jwforres reviewed Oct 29, 2015
View reviewed changes
pkg/assets/bindata.go
@@ -21650,7 +21650,7 @@ link:function(a) {
var b = function() {
"available" === a.centerLabel ? (a.currentValue = a.chartData.used, a.currentText = "Used") :(a.currentValue = a.chartData.total - a.chartData.used, a.currentText = "Available");
};
a.$watchGroup([ "centerLabel", "chartData.used", "chartData.available", "chartData.total" ], function() {
a.$watch("centerLabel", function() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't have this diff, need to update your bower deps and rebuild

@spadgett
Copy link
Member

Since we're removing the download link, might be easier for me to include this in my PR. It's two lines I already have locally :)

@benjaminapetersen
Copy link
Contributor Author

I'm good with that if you want to copy the lines over, ill close this out.

@spadgett
Copy link
Member

Fixes included in #5537.

@benjaminapetersen benjaminapetersen deleted the bpeterse/more-logs-bugs branch November 9, 2015 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benjaminapetersen @spadgett @jwforres