-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UPSTREAM: cadvisor bumps #5581
UPSTREAM: cadvisor bumps #5581
Conversation
@jimmidyson what's different? the same two upstream PRs are listed |
@liggitt Something was wrong with the other PR's bumps - deleted files still existed, e.g. |
k |
Referenced from #5107 |
@jimmidyson One nit -- will you add the sha1 for each bump to the commit message for these? I believe that is the convention we use in origin for such things. @deads2k Do you want these commits named differently aside from the sha1 of the bump? |
should be |
Reused @smarterclayton's commit messages... Will amend later. |
Do you want each bump to each godep name in a separate commit as well? e.g. |
LGTM [merge], we can live with the poorly named commits because a rebase should update them. |
[test] On Mon, Nov 2, 2015 at 3:41 PM, OpenShift Bot [email protected]
|
[test] |
github.com bower flake, re[test][merge] |
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/6673/) (Image: devenv-rhel7_2631) |
Evaluated for origin merge up to 111da86 |
Evaluated for origin test up to 111da86 |
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/6673/) |
@smarterclayton @pmorie
Supersedes #5548