Prevent deployment status string accumulation #5707
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unit test forthcoming |
| if errors.IsNotFound(err) { | ||
| details = fmt.Sprintf("The image trigger for image stream tag %q will have no effect because image stream %q does not exist.", istag, name) | ||
| if !errors.IsNotFound(err) { | ||
| return "", existingDeployments, latestDeploymentExists, fmt.Errorf("Error while trying to get image stream %q: %v", name, err) |
There was a problem hiding this comment.
your capitalization is wrong on your errors
There was a problem hiding this comment.
Already fixed with my unit test commit
Rebuild the deployment config status from scratch each time to prevent accumulating the string with old messages. Separate the algorithm into two parts: one which builds up the context for the details, and one which renders the context into a string.
ironcladlou
force-pushed
the
details-append-fix
branch
from
1cd20af to
22e4597
Compare
smarterclayton
added
priority/P1
component/apps
area/reliability
approved
|
Actually, hold on the merge - will this fetch all build configs every time there is an error now? |
|
In a loop? |
|
It USED to load build configs for every trigger every time it handled the config. Now it does it just once per handle, which is still too much. Hence the switch to a store in #5530 |
|
Introduced by #4941 |
smarterclayton
removed
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebuild the deployment config status from scratch each time to prevent
accumulating the string with old messages. Separate the algorithm into
two parts: one which builds up the context for the details, and one which
renders the context into a string.
Fixes #5706