Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constants are mismatched on BuildTriggerType #673

Merged
merged 1 commit into from
Jan 19, 2015
Merged

Constants are mismatched on BuildTriggerType #673

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pkg/build/api/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,15 +269,15 @@ type BuildTriggerPolicy struct {
type BuildTriggerType string

const (
// GithubWebHookType represents a trigger that launches builds on
// GithubWebHookBuildTriggerType represents a trigger that launches builds on
// Github webhook invocations
GithubWebHookBuildTriggerType BuildTriggerType = "github"

// GenericWebHookType represents a trigger that launches builds on
// GenericWebHookBuildTriggerType represents a trigger that launches builds on
// generic webhook invocations
GenericWebHookBuildTriggerType BuildTriggerType = "generic"

// ImageChangeType represents a trigger that launches builds on
// ImageChangeBuildTriggerType represents a trigger that launches builds on
// availability of a new version of an image
ImageChangeBuildTriggerType BuildTriggerType = "imageChange"
)
Expand Down
12 changes: 8 additions & 4 deletions pkg/build/api/v1beta1/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,13 +264,17 @@ type BuildTriggerPolicy struct {
type BuildTriggerType string

const (
// GithubWebHookType represents a trigger that launches builds on
// GithubWebHookBuildTriggerType represents a trigger that launches builds on
// Github webhook invocations
GithubWebHookType BuildTriggerType = "github"
GithubWebHookBuildTriggerType BuildTriggerType = "github"

// GenericWebHookType represents a trigger that launches builds on
// GenericWebHookBuildTriggerType represents a trigger that launches builds on
// generic webhook invocations
GenericWebHookType BuildTriggerType = "generic"
GenericWebHookBuildTriggerType BuildTriggerType = "generic"

// ImageChangeBuildTriggerType represents a trigger that launches builds on
// availability of a new version of an image
ImageChangeBuildTriggerType BuildTriggerType = "imageChange"
)

// BuildList is a collection of Builds.
Expand Down