BZ_1324273: BC edit form dirty when deleting Key-Value pair

[jhadvig]

@jwforres PTAL

[jwforres]

LGTM. @smarterclayton for approval, currently unable to remove env vars from BCs if you don't edit anything else. Fix is tiny

[smarterclayton]

Approved

[jwforres]

[merge]
On Apr 6, 2016 11:25 AM, "Clayton Coleman" [email protected] wrote:

Approved

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#8380 (comment)

[openshift-bot]

[Test]ing while waiting on the merge queue

[jwforres]

[merge]

[smarterclayton]

PhantomJS 1.9.8 (Linux) KeyValuesController #deleteEntry should delete
the key/value from the scope FAILED
    TypeError: 'undefined' is not a function (evaluating '$scope.form.$setDirty()')
        at /data/src/github.com/openshift/origin/assets/app/scripts/directives/oscKeyValues.js:9
        at /data/src/github.com/openshift/origin/assets/test/spec/directives/oscKeyValuesSpec.js:118

On Wed, Apr 6, 2016 at 5:55 PM, OpenShift Bot [email protected]
wrote:

continuous-integration/openshift-jenkins/merge FAILURE (
https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/5528/
)

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#8380 (comment)

[jwforres]

@jhadvig I am guessing the form needs to be mocked on the scope for the
spec test
On Apr 6, 2016 6:01 PM, "Clayton Coleman" [email protected] wrote:

PhantomJS 1.9.8 (Linux) KeyValuesController #deleteEntry should delete
the key/value from the scope FAILED
TypeError: 'undefined' is not a function (evaluating
'$scope.form.$setDirty()')
at /data/src/
github.com/openshift/origin/assets/app/scripts/directives/oscKeyValues.js:9
at /data/src/
github.com/openshift/origin/assets/test/spec/directives/oscKeyValuesSpec.js:118

On Wed, Apr 6, 2016 at 5:55 PM, OpenShift Bot [email protected]
wrote:

continuous-integration/openshift-jenkins/merge FAILURE (

https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/5528/
)

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#8380 (comment)

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#8380 (comment)

[jhadvig]

@jwforres @smarterclayton yep, had to update the spec. Fixed now

[openshift-bot]

Evaluated for origin test up to 4745a8f

[openshift-bot]

continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/2776/)

[jhadvig]

For some reason the extended tests are failing

Stderr from the command:

info: password for stats user admin has been set to Oe0EDRrgU2
I0407 04:29:20.292459   19308 plugins.go:62] Registered admission plugin "ServiceAccount"
I0407 04:29:20.303551   19308 plugins.go:46] Registered cloud provider "aws"
I0407 04:29:20.304499   19308 plugins.go:46] Registered cloud provider "gce"
I0407 04:29:22.373375   19398 plugins.go:62] Registered admission plugin "ServiceAccount"
I0407 04:29:22.388801   19398 plugins.go:46] Registered cloud provider "aws"
I0407 04:29:22.389899   19398 plugins.go:46] Registered cloud provider "gce"
!!! Error in test/extended/conformance.sh:51
    'return $out' exited with status 1
Call stack:
    1: test/extended/conformance.sh:51 main(...)
Exiting with status 1

@smarterclayton maybe a flake ?

[jwforres]

[merge]

[openshift-bot]

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/5541/) (Image: devenv-rhel7_3930)

[smarterclayton]

[merge]

On Thu, Apr 7, 2016 at 10:55 AM, OpenShift Bot [email protected]
wrote:

continuous-integration/openshift-jenkins/merge FAILURE (
https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/5535/
)

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#8380 (comment)

[openshift-bot]

Evaluated for origin merge up to 4745a8f