bump(github.com/openshift/openshift-sdn): 9f1f60258fcef6f0ef647a75a87

[pravisankar]

Fix for https://bugzilla.redhat.com/show_bug.cgi?id=1320430 : openshift/openshift-sdn#272
Debug improvements: openshift/openshift-sdn#273 , openshift/openshift-sdn#276 , openshift/openshift-sdn#283 , openshift/openshift-sdn#284 , openshift/openshift-sdn#286
Plugin refactor/cleanup: openshift/openshift-sdn#270 , openshift/openshift-sdn#278
Add macvlan interface to pod (for egress-router): openshift/openshift-sdn#271
Fix for https://bugzilla.redhat.com/show_bug.cgi?id=1322077 : openshift/openshift-sdn#277
Don't perform AddServiceRules with global/zero vnid when the vnid is not found: openshift/openshift-sdn#279
Do not throw spurious error msgs in SDN: openshift/openshift-sdn#280
Fix for https://bugzilla.redhat.com/show_bug.cgi?id=132294 : openshift/openshift-sdn#285
Fix for https://bugzilla.redhat.com/show_bug.cgi?id=1275904 : openshift/openshift-sdn#241

[pravisankar]

[test][extended:networking]

[openshift-bot]

Evaluated for origin test up to 00d36b1

[openshift-bot]

continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/2908/) (Extended Tests: networking)

[pravisankar]

OOM Flake in Kubelet, Networking extended tests passed

[pravisankar]

@eparis @knobunc can we get these fixes into origin?
We can bundle rest of the fixes in subsequent pr (sometime tomorrow or Thursday)

[eparis]

@danwinship @dcbw get a couple of reviews and I will merge.

[knobunc]

The changes you pulled for issue 285 and issue 277 look good to me. The other changes I spot checked looked complete too... so yeah. LGTM

[danwinship]

I thought we already agreed we weren't doing a full resync for 3.2? (#8333)

[eparis]

I think ravi is trying to argue that the number of bug fixes is so large and the non-required fixes so small/risk free....

But I'll let you tell me.

[pravisankar]

If we plan to skip/cherry-pick commits, patches won't apply smoothly due to some refactors and also we need to maintain what is synced and what is not synced to origin.
At least I feel except openshift/openshift-sdn#271 all the commits either fixes some existing issue or helps in debugging our code.

[danwinship]

At least I feel except openshift/openshift-sdn#271 all the commits either fixes some existing issue or helps in debugging our code.

agreed (although note that the debugging fixes are not actually part of this PR: debug.sh isn't synced to origin)

We probably should wait to get openshift/openshift-sdn#292 in too?

[pravisankar]

On Tue, Apr 12, 2016 at 2:01 PM, Dan Winship [email protected]
wrote:

At least I feel except openshift/openshift-sdn#271
openshift/openshift-sdn#271 all the commits
either fixes some existing issue or helps in debugging our code.

agreed (although note that the debugging fixes are not actually part of
this PR: debug.sh isn't synced to origin)

We probably should wait to get openshift/openshift-sdn#292
openshift/openshift-sdn#292 in too?

We got some more pending fixes, we can bundle them in a separate pr

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#8468 (comment)

[danwinship]

LGTM

[eparis]

approved and [merge]

[openshift-bot]

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/5584/) (Image: devenv-rhel7_3964)

[openshift-bot]

Evaluated for origin merge up to 00d36b1

[dragon9783]

LGTM