Prevent concurrent deployer pod creation

[ironcladlou]

When cancelling deployer pods while the deployment is still in a New
phase, transition the deployment to a non-terminal phase so that the
other controllers don't think the deployment is complete/failed before
the deployer pods for the cancelled deployment have actually terminated.

For #8403

[ironcladlou]

/cc @Kargakis @smarterclayton

[ironcladlou]

[test]

[smarterclayton]

[test]

[openshift-bot]

Evaluated for origin test up to 0338631

[openshift-bot]

continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/2937/)

[smarterclayton]

Approved LGTM [merge]

[smarterclayton]

Flaked on kubernetes/kubernetes#24125 [merge]

[openshift-bot]

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/5585/) (Image: devenv-rhel7_3965)

[0xmichalis]

LGTM

I am still wondering why the deployer cancellation I added didn't work even with the deployment transitioned to failed.

[smarterclayton]

[merge]

On Wed, Apr 13, 2016 at 2:06 AM, Michail Kargakis [email protected]
wrote:

LGTM

I am still wondering why the deployer cancellation I added didn't work
even with the deployment transitioned to failed.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#8478 (comment)

[smarterclayton]

Opened #8502 for the flake

On Wed, Apr 13, 2016 at 12:58 PM, Clayton Coleman [email protected]
wrote:

[merge]

On Wed, Apr 13, 2016 at 2:06 AM, Michail Kargakis <
[email protected]> wrote:

LGTM

I am still wondering why the deployer cancellation I added didn't work
even with the deployment transitioned to failed.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#8478 (comment)

[openshift-bot]

Evaluated for origin merge up to 0338631