Import from repository doesn't panic #8599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if err == nil { | ||
| tag = ref.Tag | ||
| if len(status.Tag) > 0 { | ||
| tag = status.Tag |
There was a problem hiding this comment.
This assignment doesn't use the ref. Why this if inside err == nil ?
There was a problem hiding this comment.
Good catch, this block needs to be moved outside of if err == nil.
|
Please add a test that exercises all the failure paths here |
miminar
force-pushed
the
image-importer-stacktraceless-8593
branch
2 times, most recently
from
dde538f to
8862811
Compare
|
Comments addressed. |
- Check the import status before a use of image object. - Also to set tag names on import status objects in order to produce nice output (containing tag names that failed to import). Signed-off-by: Michal Minar <[email protected]>
miminar
force-pushed
the
image-importer-stacktraceless-8593
branch
from
8862811 to
24519b0
Compare
|
LGTM thanks [merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/3286/) (Image: devenv-rhel7_4039) |
|
Evaluated for origin merge up to 24519b0 |
|
[Test]ing while waiting on the merge queue |
|
Evaluated for origin test up to 24519b0 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/3286/) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nice output (containing tag names that failed to import).
Resolves #8593
cc @smarterclayton, @legionus