Use impersonation #8672
Merged
Use impersonation #8672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deads2k
force-pushed
the
use-impersonation
branch
from
5cf6306 to
6873424
Compare
| @@ -51,6 +52,7 @@ const ( | |||
| // Roles | |||
| const ( | |||
| ClusterAdminRoleName = "cluster-admin" | |||
| WheelRoleName = "wheel" | |||
There was a problem hiding this comment.
I'd prefer something like sudo
There was a problem hiding this comment.
I'd prefer something like sudo
sudoer or sudo? I'll change the name to anything.
|
nit on role name, update bootstrappolicy test fixtures and add a test, then LGTM |
deads2k
force-pushed
the
use-impersonation
branch
from
6873424 to
12b480d
Compare
|
comments addressed. [merge] |
| os::cmd::expect_success_and_text 'oc whoami --as=system:admin' "system:admin" | ||
|
|
||
| os::cmd::expect_success 'oc login -u local-admin -p pw' | ||
| os::cmd::expect_success 'oc new-project foo' |
|
[Test]ing while waiting on the merge queue |
deads2k
force-pushed
the
use-impersonation
branch
2 times, most recently
from
45b9762 to
71b0d59
Compare
deads2k
force-pushed
the
use-impersonation
branch
from
71b0d59 to
d56acf1
Compare
|
Evaluated for origin test up to d56acf1 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/3473/) |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/3473/) (Image: devenv-rhel7_4063) |
|
Evaluated for origin merge up to d56acf1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds impersonation power for service accounts to project admins and editors (they can see the secret anyway).
It also adds a wheel group so that
oadm policy add-cluster-role-to-user wheel deads --config=openshift.local.config/master/admin.kubeconfigand then deads can dooc get clusterrolebindings --as=system:admin. I think I'd like to start recommending the approach as the way to grant yourself cluster-admin like powers without having every command be a typo risk.