support project watch resourceversion=0 #8755
Conversation
| } | ||
|
|
||
| w.emit(watch.Event{ | ||
| Type: watch.Added, |
There was a problem hiding this comment.
I know this watch isn't normal but is this what happens in normal watches? We get only Added events up to the point we start watching?
There was a problem hiding this comment.
I know this watch isn't normal but is this what happens in normal watches? We get only Added events up to the point we start watching?
After it finishes sending the adds, it will drop into the "normal" operation loop below where it will continue the watch after its initial list.
I'm pretty sure that it only gives Add events with the current state of the object instead of every individual add/modify/remove. @liggitt care to confirm or deny? Even if it did, that information isn't available here, so its the best we can do.
There was a problem hiding this comment.
yes, "ADD" with current state, not full history
|
One comment, lgtm otherwise |
|
[merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/3621/) (Image: devenv-rhel7_4113) |
|
Evaluated for origin merge up to d37235b |
|
[Test]ing while waiting on the merge queue |
|
Evaluated for origin test up to d37235b |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/3621/) |
Passing
resourceVersion=0now gives you a full list of all your projects.Also stops sending repeat modified events for projects we've already seen. I haven't stopped the re-evaluation in the project cache itself, only the emission of those events. Something in there is still recalculating more than we'd like.
@openshift/api-review I think we've agreed on the API change already
@Kargakis you've reviewed this area before. Up for another?