Import app.json to OpenShift applications #8819
Conversation
| case "secret": | ||
| param.Generate = "expression" | ||
| param.From = "[a-zA-Z0-9]{14}" | ||
| } |
There was a problem hiding this comment.
given that generators are going away in k8s templates, do we really want to invest more in them here?
There was a problem hiding this comment.
I want app.json to work - it won't today without support for generators.
On Tue, May 10, 2016 at 3:20 PM, Ben Parees [email protected]
wrote:
In pkg/generate/appjson/appjson.go
#8819 (comment):
}e := env.EnvVardisplayName := v.NamedisplayName = strings.Join(strings.Split(strings.ToLower(displayName), "_"), " ")displayName = strings.ToUpper(displayName[:1]) + displayName[1:]param := templateapi.Parameter{Name: v.Name,DisplayName: displayName,Description: e.Description,Value: e.Value,}switch e.Generator {case "secret":param.Generate = "expression"param.From = "[a-zA-Z0-9]{14}"}given that generators are going away in k8s templates, do we really want
to invest more in them here?—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/openshift/origin/pull/8819/files/89ca3f79b38ea3ffc3fd3165cec0b0394ad8bbad#r62735114
smarterclayton
force-pushed
the
appjson
branch
5 times, most recently
from
d63ba11 to
759c3ac
Compare
|
[test] |
|
Any other comments? |
| appJSONExample = ` # Import a directory containing an app.json file | ||
| $ %[1]s app.json -f . | ||
|
|
||
| # Turn an app.json file into a template |
There was a problem hiding this comment.
is this indenting intentional?
There was a problem hiding this comment.
this is my last remaining comment ^^
smarterclayton
force-pushed
the
appjson
branch
2 times, most recently
from
042c69e to
81b62af
Compare
|
Flake #9144 On Thu, Jun 2, 2016 at 2:45 PM, OpenShift Bot [email protected]
|
Makes it easier for a user to use lifecycle hooks for single container pods.
|
Evaluated for origin test up to 80cf1e9 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/4384/) |
|
[merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/4384/) (Image: devenv-rhel7_4304) |
|
Evaluated for origin merge up to 80cf1e9 |
Experimental support for importing app.json to an OpenShift/Kubernetes application. Handles formations, has to make some informed guesses to get the right container start command. Assumes the build image accepts source (so we do a FROM ; ADD .; COMMIT).