add scoped impersonation #8824
Merged
add scoped impersonation #8824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please tell me I can impersonate myself. |
|
Obviously that's too dangerous |
|
|
@soltysh mind taking a quick look? It's small and I know you've spent time in the handler |
|
LGTM |
|
[merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/5885/) (Image: devenv-rhel7_4166) |
|
Evaluated for origin merge up to 640c27e |
|
[Test]ing while waiting on the merge queue |
|
Evaluated for origin test up to 640c27e |
|
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/3750/) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For https://trello.com/c/CqdFNLkd/697-3-auth-scopes-scoped-acting-as
This allows someone to act as a user and limit themselves to the scopes provided on the token. This is useful for cases where our API talks back to itself and wants to switch to an impersonation model. Doing this would prevent a token from accidentally being escalated.
@sgallagher ptal