Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

o Add locking around ops that change state. Its better to go lockless eventually and use a "shadow" (cloned) copy of the config when we do a reload. o Fixes as per @smarterclayton review comments. #8993

Merged

Conversation

smarterclayton
Copy link
Contributor

No description provided.

  lockless eventually and use a "shadow" (cloned) copy of the
  config when we do a reload.
o Fixes as per @smarterclayton review comments.
@openshift-bot
Copy link
Contributor

Origin Action Required: Only pull request(s) from ["master"] are handled by the openshift-bot

@deads2k
Copy link
Contributor

deads2k commented May 24, 2016

@danmcp another unprotected one. Also, why is our bot master specific?

@danmcp
Copy link

danmcp commented May 24, 2016

@deads2k You should talk to the person who added the branch about protecting it.

As far as the bot. There are a few steps to enable multiple branches.

  1. Have branch specific images to corresponding to any special requirements in the branches if necessary.
  2. Update the jobs to accept a branch. That's only been done for test so far [test] for far. [testonlyextended] and [merge] are not covered yet.
  3. Update the bot to allow multiple branches (only takes a few seconds when we are ready)

@deads2k
Copy link
Contributor

deads2k commented May 24, 2016

Now with protection.

@smarterclayton we're going to run a service stream on 1.2?

@smarterclayton
Copy link
Contributor Author

I'm considering it.

@smarterclayton
Copy link
Contributor Author

But right now I'm just getting everything I need to cut 1.2, given that none of our infra is set up to support it.

@smarterclayton smarterclayton merged commit e0b4ef6 into openshift:release-1.2 May 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants