add ROUTER_SLOWLORIS_TIMEOUT enviroment variable to default HAProxy image #9003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. @ramr PTAL |
|
LGTM |
|
[test] |
|
should we also have a default value for the |
Using the HAProxy router to impliement basic DDOS protection. When the enviroment variable ROUTER_SLOWLORIS_TIMEOUT is set it limits the amount of time a client has to send their whole HTTP request or HAProxy will shut down the connection BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1328037 changelog - intial commit - changed to default to 10s timeout
JacobTanenbaum
force-pushed
the
DDOS_SlowLoris
branch
from
9200f04 to
2142f8a
Compare
|
[test] |
|
@danmcp: yes... may I merge it? |
|
Does this conflict in any way with https://trello.com/c/1sdA2XVR/55-3-allow-configurable-timeout-on-routes-traffic-ingress I doubt it... |
|
@eparis: no, that change is orthogonal. And @JacobTanenbaum will probably be implementing that card anyway :-) |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/5101/) (Image: devenv-rhel7_4414) |
|
[test] |
|
Evaluated for origin test up to 2142f8a |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/5090/) |
|
[merge] |
|
Evaluated for origin merge up to 2142f8a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the HAProxy router to impliement basic DDOS protection. When the
enviroment variable ROUTER_SLOWLORIS_TIMEOUT is set it limits the amount
of time a client has to send their whole HTTP request or HAProxy will
shut down the connection
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1328037