Bug 1340735: update dc image at most once on automatic=false #9096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xmichalis
added
kind/bug
|
LGTM, I assume we don't have any test to verify this works as expected. |
I will add an integration test for this |
|
@mfojtik test added, PTAL [test] |
|
LGTM |
|
(wait for @ironcladlou to double check) |
|
Will merge on green |
Images were constantly updated before the initial deployment would kick off. Not anymore.
|
yum and #7706 combined for a flakier world [test] |
|
Evaluated for origin test up to 91ec89c |
|
This LGTM, good idea. |
|
[merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/4385/) (Image: devenv-rhel7_4304) |
|
Evaluated for origin merge up to 91ec89c |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/4385/) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Images were constantly updated before the initial deployment would
kick off. Not anymore.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1340735
@mfojtik @ironcladlou PTAL