If --public-hostname is an IP, use it for server IP in cluster up

[smarterclayton]

Otherwise users have no way to force a public IP.

@csrwng let me know if there's an alternative way you'd like to fix this. I guess it's possible users have a private server IP that they want to use, but they'd be no worse off than they are today.

[csrwng]

Seems reasonable to me. LGTM
btw, aren't you supposed to be on pto :-) ?

[smarterclayton]

[merge]

[openshift-bot]

[Test]ing while waiting on the merge queue

[csrwng]

looks like image stream wasn't imported in time
[merge]

[smarterclayton]

[merge]

[smarterclayton]

[test]

[openshift-bot]

Evaluated for origin test up to 0b992a2

[openshift-bot]

continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/4340/)

[smarterclayton]

[merge]

On Thu, Jun 2, 2016 at 2:55 AM, OpenShift Bot [email protected]
wrote:

continuous-integration/openshift-jenkins/merge FAILURE (
https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/4343/)

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#9103 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ABG_p-iQ74726SaDZe1I4l4eqvcrm9dNks5qHn5bgaJpZM4IrHmm
.

[openshift-bot]

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/4390/) (Image: devenv-rhel7_4304)

[smarterclayton]

Jun  2 13:31:50.045: INFO: stderr: ""
Jun  2 13:31:50.045: INFO: Unknown output type: . Skipping.
Jun  2 13:31:50.045: INFO: Waiting up to 1m0s for all nodes to be ready
STEP: Destroying namespace "e2e-tests-services-t2i03" for this suite.
E0602 13:33:41.214662    9968 iowatcher.go:109] Unable to decode an event from the watch stream: net/http: request canceled (Client.Timeout exceeded while reading body)
Jun  2 13:36:50.079: INFO: Pod e2e-tests-services-t2i03 hostexec on node 172.18.13.111 remains, has deletion timestamp 2016-06-02 13:32:20 -0400 EDT
Jun  2 13:36:50.079: FAIL: Couldn't delete ns "e2e-tests-services-t2i03": namespace e2e-tests-services-t2i03 was not deleted within limit: timed out waiting for the condition, pods remaining: [hostexec]


• Failure in Spec Teardown (AfterEach) [353.890 seconds]
[k8s.io] Services
/data/src/github.com/openshift/origin/Godeps/_workspace/src/k8s.io/kubernetes/test/e2e/framework.go:420
  should be able to create a functioning NodePort service [AfterEach]
  /data/src/github.com/openshift/origin/Godeps/_workspace/src/k8s.io/kubernetes/test/e2e/service.go:404

This looks similar to failures we were seeing in the upstream suite, where the watch was getting terminated due to another failure, but we didn't catch / handle it correctly.

[merge]

[openshift-bot]

Evaluated for origin merge up to 0b992a2