dockerbuild pulls all images rather than :latest #9104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A FROM foo/bar in a Dockerfile will result in docker pulling all tags in foo/bar, rather than just foo/bar:latest. Default to :latest in the dockerbuilder.
|
@csrwng as well |
|
[test] |
| repository, _ := docker.ParseRepositoryTag(from) | ||
| repository, tag := docker.ParseRepositoryTag(from) | ||
| if len(tag) == 0 { | ||
| tag = "latest" |
There was a problem hiding this comment.
This package can't take any dependencies on other OpenShift code, because we're going to move this out of the repo.
|
apart from minor suggestion, LGTM |
|
[test] |
|
Evaluated for origin test up to 020d51f |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/4393/) |
|
[merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/4393/) (Image: devenv-rhel7_4305) |
|
Evaluated for origin merge up to 020d51f |
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A FROM foo/bar in a Dockerfile will result in docker pulling all tags in
foo/bar, rather than just foo/bar:latest. Default to :latest in the
dockerbuilder.
@mfojtik review please, hit this while fixing other things