Fixes get --show-labels for OpenShift resources
#9152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, it should be exposed upstream. |
fabianofranz
force-pushed
the
issues_9114
branch
3 times, most recently
from
ba45b01 to
2ab6494
Compare
fabianofranz
changed the title
get --show-labels for OpenShift resourcesget --show-labels for OpenShift resources
|
[test] |
|
@smarterclayton please review. |
fabianofranz
force-pushed
the
issues_9114
branch
2 times, most recently
from
e9409a2 to
58828b1
Compare
|
Evaluated for origin test up to b691eeb |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/4475/) |
|
LGTM [merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/4475/) (Image: devenv-rhel7_4319) |
|
Evaluated for origin merge up to b691eeb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9114
WIP fixes deployment configs, still need to check and fix other OpenShift resources if needed. Also pending tests.
@smarterclayton are you ok with exposing
append*Labelsfuncs in the printer upstream?