router: Add name and namespace templates params #9159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add "Name" and "Namespace" to ServiceAliasConfig, and set them in the template router's AddRoute, in order to make these route parameters available for custom configuration templates.
|
I created an example template that uses these parameters in order to restrict the use of custom certificates and hosts to routes in specific namespaces. |
|
openshift-bot, please [test] again! |
|
LGTM @smarterclayton PTAL This is much less scary! Thanks @Miciah |
|
lgtm as well [merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/4446/) (Image: devenv-rhel7_4312) |
|
Evaluated for origin merge up to 85f67f5 |
|
Flaked again. Please [test] again! |
|
Evaluated for origin test up to 85f67f5 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/4446/) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
NameandNamespacetoServiceAliasConfig, and set them in the template router'sAddRoute, in order to make these route parameters available for custom configuration templates.[test]