Fix import-image --all #9163
Fix import-image --all #9163
Conversation
|
[test] |
|
Rebased due to weird test failures. This is ready for review @smarterclayton or @miminar ptal |
| } | ||
| } | ||
| if len(tags) == 0 { | ||
| return nil, fmt.Errorf("image stream does not have importable tags (pointing to DockerImage)") |
There was a problem hiding this comment.
The message needs to be improved
There was a problem hiding this comment.
Apparently it'll be fixed/changed, due to https://bugzilla.redhat.com/show_bug.cgi?id=1343681. But that will be rather a followup to this one. For now I'll go with: 'image stream does not have tags pointing to external docker images'
|
@smarterclayton does this look good to you now? |
|
Yeah, squash |
|
Done. |
|
Evaluated for origin test up to fa40c7d |
|
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/4605/) |
|
LGTM [merge] On Wed, Jun 8, 2016 at 12:20 PM, OpenShift Bot [email protected]
|
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/4641/) (Image: devenv-rhel7_4338) |
|
Evaluated for origin merge up to fa40c7d |
Fixes #8952.