add openshift ex config patch to modify master-config.yaml

[deads2k]

Introduces openshift ex config patch path/to/master-config.yaml --patch '{}' to allow master config mutation without using sed. The scheme changes and patch flag additions may take us a little while to work out, this gives us a removable command to play with and see if it suits us.

@fabianofranz
@soltysh @stevekuznetsov

[deads2k]

[test]

[soltysh]

LGTM

[deads2k]

[merge]

[fabianofranz]

+1 LGTM

[deads2k]

yum re[merge]

[smarterclayton]

When would I use this over improvements to the other patch?

[deads2k]

When would I use this over improvements to the other patch?

Two problems:

1. Our config objects exist in a different scheme and a lot of code, include patch, rely on a single scheme. It's not insurmountable, but not something I want to rush into either. I'd want to create a new API group and find a way to decode using a "trust me" serialized version.
2. The upstream patch changes looks like they're going to take a little while. I think they'll come around, but this is blocking our ability to fully test conformance on different configs now (audit in particular).

I figured on having an experimental command until we get everything sorted out in a few weeks and pick up changes in another rebase.

[stevekuznetsov]

but this is blocking our ability to fully test conformance

To be fair, this is the Golang program that we can write to alleviate our block:

package main

import (
    "io/ioutil"
    "os"

    "gopkg.in/yaml.v2"

    "github.com/openshift/origin/pkg/cmd/server/api/v1"
)

func main() {
    var config v1.MasterConfig

    rawInput, err := ioutil.ReadFile(os.Args[1])
    if err != nil {
        panic(err)
    }

    err = yaml.Unmarshal(rawInput, &config)
    if err != nil {
        panic(err)
    }

    config.AuditConfig.Enabled = true

    rawOutput, err := yaml.Marshal(config)
    if err != nil {
        panic(err)
    }

    err = ioutil.WriteFile(os.Args[1]+".updated", rawOutput, os.O_WRONLY|O_CREATE)
    if err != nil {
        panic(err)
    }
}

[mfojtik]

yey! 👍

[smarterclayton]

That's fine - I would expect though that the upstream patch command replace this command.

[deads2k]

That's fine - I would expect though that the upstream patch command
replace this command.

Agreed. yum re[merge]

[openshift-bot]

Evaluated for origin test up to 5920c0b

[openshift-bot]

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/4496/)

[openshift-bot]

Evaluated for origin merge up to 5920c0b

[openshift-bot]

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/4496/) (Image: devenv-rhel7_4324)