CLI: command to set deployment hooks on deployment configs #9187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bparees ptal |
| %[1]s deployment-hook dc/myapp --pre -v data -- /var/lib/migrate-db.sh | ||
|
|
||
| # Set a mid deployment hook along with additional environment variables | ||
| %[1]s deployment-hook dc/myapp --mid -v data -e VAR1=value1,VAR2=value2 -- /var/lib/prepare-deploy.sh` |
There was a problem hiding this comment.
i thought we were moving away from comma separated env variables and moving to mulitple -e args instead?
csrwng
force-pushed
the
set_deplhook
branch
2 times, most recently
from
03be1d3 to
944a767
Compare
|
updated |
csrwng
force-pushed
the
set_deplhook
branch
3 times, most recently
from
e44eed4 to
3a5accb
Compare
|
[test] |
|
@openshift/api-review |
|
Evaluated for origin test up to e8c6533 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/4663/) |
|
lgtm [merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/4663/) (Image: devenv-rhel7_4342) |
|
Evaluated for origin merge up to e8c6533 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'oc set deployment-hook' command
Implements #9040