CLI: set build-hook command #9194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bparees ptal |
csrwng
force-pushed
the
set_buildhook
branch
2 times, most recently
from
3772625 to
01f3ddd
Compare
|
[test] |
1 similar comment
|
[test] |
|
Evaluated for origin test up to 01f3ddd |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/4548/) |
| cmd.Flags().StringSliceVarP(&options.Filenames, "filename", "f", options.Filenames, "Filename, directory, or URL to file to use to edit the resource.") | ||
|
|
||
| cmd.Flags().BoolVar(&options.PostCommit, "post-commit", options.PostCommit, "If true, set the post-commit build hook on a build config") | ||
| cmd.Flags().BoolVar(&options.Entrypoint, "command", options.Entrypoint, "If true, set the entrypoint of the hook container to the given command") |
There was a problem hiding this comment.
I would prefer to use the same syntax as for exec probes here --
There was a problem hiding this comment.
Hrm, wondering if people expect this to be the default.
There was a problem hiding this comment.
I guess this is fine.
|
lgtm [merge] |
|
Evaluated for origin merge up to 01f3ddd |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/4548/) (Image: devenv-rhel7_4330) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows setting a post-commit build hook on a build config.
If re-using built image entrypoint:
If specifying a new entrypoint:
If specifying a script:
Although there's only one type of hook is currently allowed, the argument with the type of hook must be specified (
--post-commit).