atomic-registry via systemd #9200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@smarterclayton this is the systemd prototype deployment |
| --entrypoint /usr/bin/uninstall.sh \ | ||
| $IMAGE' | ||
|
|
||
| ADD atomic-registry-master.service \ |
There was a problem hiding this comment.
It would probably be better to put these in a subfolder and include it as one or two top level folders. Generally that reduces churn to the Dockerfile and also avoids missing file issues.
|
LGTM, squash please. |
aweiteka
force-pushed
the
atomic-registry-systemd
branch
from
4f4751c to
5fe10a4
Compare
aweiteka
force-pushed
the
atomic-registry-systemd
branch
from
5fe10a4 to
0a025a8
Compare
|
@smarterclayton done. thx. |
|
[merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/4920/) (Image: devenv-rhel7_4383) |
|
Evaluated for origin merge up to 0a025a8 |
|
[Test]ing while waiting on the merge queue |
|
Evaluated for origin test up to 0a025a8 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/4920/) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.