Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UPSTREAM: 27048: fixes to the kubectl scaler #9228

Merged
merged 2 commits into from
Jun 17, 2016
Merged

UPSTREAM: 27048: fixes to the kubectl scaler #9228

merged 2 commits into from
Jun 17, 2016

Conversation

0xmichalis
Copy link
Contributor

No description provided.

@0xmichalis 0xmichalis mentioned this pull request Jun 8, 2016
Closed
@0xmichalis
Copy link
Contributor Author

0xmichalis commented Jun 13, 2016 •
edited
Loading

@smarterclayton @ironcladlou @mfojtik this is huge for UX, see #9216

@0xmichalis
Copy link
Contributor Author

[test]

@smarterclayton
Copy link
Contributor

Right after the rebase?

@0xmichalis
Copy link
Contributor Author

I am fine with it

On Mon, Jun 13, 2016 at 5:06 PM, Clayton Coleman [email protected]
wrote:

Right after the rebase?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#9228 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ADuFf3AyyDI2LHpQ5BmY_LTgsgr9omvuks5qLXHmgaJpZM4IxILg
.

@openshift-bot openshift-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 16, 2016
@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 7447e82

@openshift-bot openshift-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 16, 2016
@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/4960/)

@0xmichalis 0xmichalis assigned mfojtik and unassigned 0xmichalis Jun 17, 2016
@0xmichalis
Copy link
Contributor Author

@mfojtik can I get a review for this?

@smarterclayton
Copy link
Contributor

LGTM

@smarterclayton
Copy link
Contributor

[merge]

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 17, 2016 •
edited
Loading

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/5061/) (Image: devenv-rhel7_4398)

@0xmichalis
Copy link
Contributor Author

conformance tests never came up, re[merge]

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 7447e82

@openshift-bot openshift-bot merged commit 13d4b7e into openshift:master Jun 17, 2016
@0xmichalis 0xmichalis deleted the ignore-only-409-in-scaler branch June 17, 2016 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mfojtik mfojtik

Labels
area/usability component/apps component/cli priority/P2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@0xmichalis @smarterclayton @openshift-bot @mfojtik