Update DockerImageReferences when tagging across image streams #9238

smarterclayton · 2016-06-09T01:09:59Z

The docker image reference to an internal image (in the local registry) should be updated during a tag, so if the original image stream is deleted pulls don't fail.

I.e.

Create image stream foo
Push image @1 to it
Tag @1 to image stream bar
Delete image stream foo
Try to pull bar@1 - fails

Also adds:

Allow dockerImageReference on an Image to be updated
Add oc create imagestream
ImageStreamMapping should default dockerImageReference if not set
Add --reference to oc tag
Add tests

smarterclayton · 2016-06-09T01:10:34Z

@miminar @liggitt this leads up to migrating docker image references when the user changes repository names.

miminar · 2016-06-09T07:36:46Z

pkg/cmd/cli/cmd/create/imagestream.go

+	Printer      ObjectPrinter
+}
+
+// NewCmdCreateServiceAccount is a macro command to create a new image stream


Outdated godoc.

miminar · 2016-06-09T08:01:12Z

Could you please better describe commit message of "Allow mutation of image dockerImageReference"?

miminar · 2016-06-09T08:08:10Z

pkg/image/registry/imagestreammapping/rest.go

-// New returns a new ImageStreamMapping for use with Create.
-func (r *REST) New() runtime.Object {
-	return &api.ImageStreamMapping{}
+func NewImageStreamMappingStrategy(defaultRegistry api.DefaultRegistry) Strategy {


NewStrategy? Also the godoc doesn't match.

miminar · 2016-06-09T10:41:15Z

We should set up a controller for fixing such cases for existing entries. It could handle a lot of other cases we don't address today:

post-corrections for re-deployment of docker-registry service - dockerImageReferences outdated
deleting tags having just references to images no longer in internal registry
updating of some global map of blob ↔️ repository mapping - useful for pullthrough and image pruning

smarterclayton · 2016-06-09T14:25:44Z

We're not going to do a controller because there are other use cases for changing these values - ie when an external registry changes and the admin has to react. The migrate PR will implement that. We are not going to do a global map lookup, it's more complex and doesn't fit our API style (which is simple denormalized objects). Prune should handle removing tags.

miminar · 2016-06-10T08:01:24Z

pkg/image/registry/image/etcd/etcd_test.go

@@ -310,8 +310,8 @@ func TestUpdateResetsMetadata(t *testing.T) {
 					t.Errorf("unexpected docker image: %#v", image.DockerImageMetadata)
 					return false
 				}
-				if image.DockerImageReference != "openshift/ruby-19-centos-2" {
-					t.Errorf("image reference changed: %s", image.DockerImageReference)
+				if image.DockerImageReference == "openshift/ruby-19-centos-2" {


Could you also check against expected value?

miminar · 2016-06-10T08:13:13Z

One nit. LGTM otherwise.

ncdc · 2016-06-10T14:57:52Z

Can we finally get around to removing storing image.dockerImageReference in etcd?

soltysh · 2016-06-10T15:10:21Z

pkg/cmd/cli/cmd/create/imagestream.go

+	switch len(args) {
+	case 0:
+		return fmt.Errorf("image stream name is required")
+	case 1:


Can we at least have --image or something like that, which will create a non-empty ImageStream?

Not here. That's what tag does.

smarterclayton · 2016-06-10T21:11:04Z

I think i've flipped - we want to store the image reference. It's strictly less complex than a mapping solution, and now that we have a migration story developing it's manageable.

smarterclayton · 2016-06-10T21:12:39Z

[merge]

openshift-bot · 2016-06-10T21:15:23Z

[Test]ing while waiting on the merge queue

openshift-bot · 2016-06-11T00:15:24Z

continuous-integration/openshift-jenkins/test Running (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/4782/)

openshift-bot · 2016-06-11T12:00:19Z

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/4789/) (Image: devenv-rhel7_4363)

Reference tags are not imported, but simply linked

Enables simple creation of an image stream

Admins should be able to update dockerImageReference on an image so that migrations can be performed via the API.

If the caller does not provide a DIR, set the DIR to be the pullthrough location for this image stream. This enables non-registry clients to submit images more easily, primarily for testing, but will also be used in future registry to avoid the need to set the value.

The hasScheduled flag was being reset

If the image reference we are copying in an image stream points to the internal registry, update the docker pull spec to the current image stream so that deleting the original image stream has no impact. Add more extensive tests of this behavior.

openshift-bot · 2016-06-13T18:10:45Z

Evaluated for origin test up to 33b455a

openshift-bot · 2016-06-13T18:10:54Z

Evaluated for origin merge up to 33b455a

smarterclayton force-pushed the update_image_ref branch from 583d21a to 7d726a8 Compare June 9, 2016 01:11

miminar reviewed Jun 9, 2016
View reviewed changes

smarterclayton force-pushed the update_image_ref branch from 7d726a8 to e23f741 Compare June 9, 2016 17:11

miminar reviewed Jun 10, 2016
View reviewed changes

soltysh reviewed Jun 10, 2016
View reviewed changes

smarterclayton force-pushed the update_image_ref branch from e23f741 to fbc0514 Compare June 10, 2016 21:12

smarterclayton force-pushed the update_image_ref branch from fbc0514 to c9c49d3 Compare June 10, 2016 22:45

smarterclayton force-pushed the update_image_ref branch from c9c49d3 to 5dbc59d Compare June 13, 2016 18:05

smarterclayton added 2 commits June 13, 2016 14:06

Allow --reference to be passed to oc tag

7120266

Reference tags are not imported, but simply linked

Add 'oc create imagestream'

2f76071

Enables simple creation of an image stream

smarterclayton added 4 commits June 13, 2016 14:06

Allow mutation of image dockerImageReference

04f7e2d

Admins should be able to update dockerImageReference on an image so that migrations can be performed via the API.

Bug in oc describe imagestream

33b455a

The hasScheduled flag was being reset

openshift-bot merged commit c02ce07 into openshift:master Jun 13, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update DockerImageReferences when tagging across image streams #9238

Update DockerImageReferences when tagging across image streams #9238

smarterclayton commented Jun 9, 2016 •

edited

Loading

smarterclayton commented Jun 9, 2016

miminar Jun 9, 2016

miminar commented Jun 9, 2016

miminar Jun 9, 2016

miminar commented Jun 9, 2016

smarterclayton commented Jun 9, 2016 via email

miminar Jun 10, 2016

smarterclayton Jun 10, 2016 via email

miminar commented Jun 10, 2016

ncdc commented Jun 10, 2016

soltysh Jun 10, 2016

smarterclayton Jun 10, 2016

smarterclayton commented Jun 10, 2016

smarterclayton commented Jun 10, 2016

openshift-bot commented Jun 10, 2016

openshift-bot commented Jun 11, 2016 •

edited

Loading

openshift-bot commented Jun 11, 2016 •

edited

Loading

openshift-bot commented Jun 13, 2016

openshift-bot commented Jun 13, 2016

Update DockerImageReferences when tagging across image streams #9238

Update DockerImageReferences when tagging across image streams #9238

Conversation

smarterclayton commented Jun 9, 2016 • edited Loading

smarterclayton commented Jun 9, 2016

miminar Jun 9, 2016

Choose a reason for hiding this comment

miminar commented Jun 9, 2016

miminar Jun 9, 2016

Choose a reason for hiding this comment

miminar commented Jun 9, 2016

smarterclayton commented Jun 9, 2016 via email

miminar Jun 10, 2016

Choose a reason for hiding this comment

smarterclayton Jun 10, 2016 via email

Choose a reason for hiding this comment

miminar commented Jun 10, 2016

ncdc commented Jun 10, 2016

soltysh Jun 10, 2016

Choose a reason for hiding this comment

smarterclayton Jun 10, 2016

Choose a reason for hiding this comment

smarterclayton commented Jun 10, 2016

smarterclayton commented Jun 10, 2016

openshift-bot commented Jun 10, 2016

openshift-bot commented Jun 11, 2016 • edited Loading

openshift-bot commented Jun 11, 2016 • edited Loading

openshift-bot commented Jun 13, 2016

openshift-bot commented Jun 13, 2016

smarterclayton commented Jun 9, 2016 •

edited

Loading

openshift-bot commented Jun 11, 2016 •

edited

Loading

openshift-bot commented Jun 11, 2016 •

edited

Loading