-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cluster up: optionally install metrics components #9310
Conversation
@smarterclayton ptal |
f793535
to
3f24483
Compare
Opened the following issues on origin-metrics: |
}, | ||
}, | ||
} | ||
pod.GenerateName = "metrics-deployer-" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you using a generate name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hadn't given it much thought. The original template has a generate name. But in my case, I guess it doesn't make much sense. I'll switch it to a regular name.
No other comments beyond that. |
3f24483
to
141cc0f
Compare
Comment addressed. Also added a line with the metrics URL in the info part when you specify the --metrics flag:
|
LGTM [merge] |
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/4903/) (Image: devenv-rhel7_4382) |
Evaluated for origin merge up to 141cc0f |
[Test]ing while waiting on the merge queue |
Evaluated for origin test up to 141cc0f |
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/4903/) |
Adds an experimental flag to
oc cluster up
to install metrics components.When specifying the --metrics flag, the master asset config is updated with the hostname for the metrics route and the pod to deploy metrics components is created.