Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster up: optionally install metrics components #9310

Merged
merged 1 commit into from
Jun 15, 2016

Conversation

csrwng
Copy link
Contributor

@csrwng csrwng commented Jun 13, 2016

Adds an experimental flag to oc cluster up to install metrics components.

When specifying the --metrics flag, the master asset config is updated with the hostname for the metrics route and the pod to deploy metrics components is created.

@csrwng
Copy link
Contributor Author

csrwng commented Jun 13, 2016

@smarterclayton ptal
/cc @jwforres @spadgett

@csrwng csrwng force-pushed the clusterup_metrics branch from f793535 to 3f24483 Compare June 13, 2016 20:44
@csrwng
Copy link
Contributor Author

csrwng commented Jun 13, 2016

Opened the following issues on origin-metrics:
openshift/origin-metrics#148 - Reduce memory footprint
openshift/origin-metrics#149 - Heapster not collecting metrics on docker machine OS

},
},
}
pod.GenerateName = "metrics-deployer-"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you using a generate name?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hadn't given it much thought. The original template has a generate name. But in my case, I guess it doesn't make much sense. I'll switch it to a regular name.

@smarterclayton
Copy link
Contributor

No other comments beyond that.

@csrwng csrwng force-pushed the clusterup_metrics branch from 3f24483 to 141cc0f Compare June 15, 2016 14:44
@csrwng
Copy link
Contributor Author

csrwng commented Jun 15, 2016

Comment addressed.

Also added a line with the metrics URL in the info part when you specify the --metrics flag:

-- Server Information ...
   OpenShift server started.
   The server is accessible via web console at:
       https://192.168.56.1:8443

   The metrics service is available at:
       https://metrics-openshift-infra.192.168.56.1.xip.io

   You are logged in as:
       User:     developer
       Password: developer

   To login as administrator:
       oc login -u system:admin

@smarterclayton
Copy link
Contributor

LGTM [merge]

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 15, 2016

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/4903/) (Image: devenv-rhel7_4382)

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 141cc0f

@openshift-bot
Copy link
Contributor

[Test]ing while waiting on the merge queue

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 141cc0f

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/4903/)

@openshift-bot openshift-bot merged commit af724eb into openshift:master Jun 15, 2016
@csrwng csrwng deleted the clusterup_metrics branch July 19, 2016 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants