deploy: fix initial image change deployments #9539
Conversation
|
[testextended][extended:core(Docker image source)] |
|
Evaluated for origin testextended up to 7aeb1a7 |
|
@mfojtik ptal |
|
continuous-integration/openshift-jenkins/testextended SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin_extended/230/) (Extended Tests: core(Docker image source)) |
|
green extended test [merge] @mfojtik review at your pleasure |
|
[Test]ing while waiting on the merge queue |
|
Evaluated for origin test up to 7aeb1a7 |
| // triggers and compare with the present trigger. Initial deployments | ||
| // should always trigger since there is no previous config to compare to. | ||
| if config.Status.LatestVersion > 0 { | ||
| if !triggeredByDifferentImage(*t.ImageChangeParams, *decoded) { |
There was a problem hiding this comment.
if config.Status.LatestVersion > 0 && !triggeredByDifferentImage(*t.ImageChangeParams, *decoded) {
}There was a problem hiding this comment.
Will fix in #9349 where I am moving all this code in rest.
|
@Kargakis one nit, LGTM |
|
@Kargakis merge at green. |
|
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/5363/) |
|
Flaked on #9444. [merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/5417/) (Image: devenv-rhel7_4462) |
|
[merge] |
|
Evaluated for origin merge up to 7aeb1a7 |
Fixes #9530