ignore build version on bc update if version is older than existing value #9568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[test] |
bparees
force-pushed
the
ignore_build_version
branch
from
e605d76 to
5f909d2
Compare
|
infrastructure flake. [test] |
|
Evaluated for origin test up to 5f909d2 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/5436/) |
|
LGTM |
|
[merge] Ben Parees | OpenShift
|
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/5438/) (Image: devenv-rhel7_4467) |
|
Evaluated for origin merge up to 5f909d2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #9301
@Kargakis @csrwng ptal. I know the "right" fix here is to change the default bc resource to ignore status updates, and introduce a new resource that accepts status updates (and possibly spec updates) and use that from our clone/instantiate logic when updating a BC, but this seems simpler and sufficient for now. I can't think of any reason we'd want to let someone update a BC to make the status older than the current value (especially if the right fix wouldn't let them update the BC status at all anyway).