Limit the number of events and deployments displayed in dc describer #9633
Conversation
|
@Kargakis PTAL |
| counter++ | ||
| } | ||
| // Only show last three deployments here | ||
| if counter == 2 { |
There was a problem hiding this comment.
Add a comment that this number needs to be on par with the respective number in oc status
There was a problem hiding this comment.
@Kargakis I can make it a const
There was a problem hiding this comment.
Oh, I didn't realize we are on the same package. Yes, please, make it a constant.
| const ( | ||
| // MaxDisplayDeployments is the number of deployments to show when describing | ||
| // deployment configuration. | ||
| // TODO: Use this constant when limiting the number of deployments displayed in |
There was a problem hiding this comment.
Plug this in oc status while here. Also we don't need to export any of these constants.
openshift-bot
added
the
needs-rebase
|
@Kargakis fixed the count and plumbed |
| const ( | ||
| // maxDisplayDeployments is the number of deployments to show when describing | ||
| // deployment configuration. | ||
| // TODO: Use this constant when limiting the number of deployments displayed in |
|
One last comment, LGTM otherwise |
|
@Kargakis done. will merge on green tests |
openshift-bot
removed
the
needs-rebase
|
[merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/5670/) (Image: devenv-rhel7_4502) |
|
Evaluated for origin merge up to 18929ed |
|
[Test]ing while waiting on the merge queue |
|
Evaluated for origin test up to 18929ed |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/5670/) |
Fixes: #9604
This PR will limit the events displayed to last 4 and also the deployments displayed in describe to last 3.