Update resource builder error message to be more clear #9735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fabianofranz Could you please take a look? |
|
[test] |
| @@ -354,7 +354,8 @@ func hasCombinedTypeArgs(args []string) (bool, error) { | |||
| case hasSlash > 0 && hasSlash == len(args): | |||
| return true, nil | |||
| case hasSlash > 0 && hasSlash != len(args): | |||
| return true, fmt.Errorf("when passing arguments in resource/name form, all arguments must include the resource") | |||
| // return true, fmt.Errorf("when passing arguments in resource/name form, all arguments must include the resource") | |||
| return true, fmt.Errorf("there is no need to specify a resource type as a separate argument when passing arguments in resource/name form (e.g. `oc get resource/<resource_name>` instead of `oc get resource resource/<resource_name>`") | |||
There was a problem hiding this comment.
no markdown support in bash yet, so use ' instead of ``` :)
|
LGTM, can be proposed upstream |
juanvallejo
force-pushed
the
jvallejo_update-resource-builder-format-error
branch
from
060ef17 to
775b8ee
Compare
juanvallejo
changed the title
juanvallejo
force-pushed
the
jvallejo_update-resource-builder-format-error
branch
2 times, most recently
from
fb04408 to
6cd66bb
Compare
openshift-bot
added
the
needs-rebase
juanvallejo
force-pushed
the
jvallejo_update-resource-builder-format-error
branch
from
6cd66bb to
d808595
Compare
|
Evaluated for origin test up to d808595 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/6203/) |
openshift-bot
removed
the
needs-rebase
|
@fabianofranz PR merged upstream: kubernetes/kubernetes#28626 |
|
[merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/6283/) (Image: devenv-rhel7_4591) |
|
Evaluated for origin merge up to d808595 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error message given by command line "oc get" is sometimes of no help / not clear on what must be corrected, e.g.：
oc get pod pods/docker-registry-4-3tesderror: when passing arguments in resource/name form, all arguments must include the resource
oc get bc bc/not-existing-bcerror: when passing arguments in resource/name form, all arguments must include the resource
Steps to Reproduce:
Actual Result:
Get unfriendly error message which is of no help:
"error: when passing arguments in resource/name form, all arguments must include the resource"
Expected Result:
Error message should recommend end user to run this cli in good grammar: "# oc get po docker-registry-4-3tesd"
Before
"error: when passing arguments in resource/name form, all arguments must include the resource"
After
"error: there is no need to specify a resource type as a separate argument when passing arguments in resource/name form (e.g.
oc get resource/<resource_name>instead ofoc get resource resource/<resource_name>"Related bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1342383
Related UPSTREAM: kubernetes/kubernetes#28626