Add mirror env var options and fix required parameters to templates #9754
Conversation
|
@dinhxuanvu did you use https://github.com/openshift/origin/blob/master/hack/update-external-examples.sh to update these files? |
|
also you need to run hack/gen-bootstrap-bindata.sh |
dinhxuanvu
force-pushed
the
add-mirror
branch
2 times, most recently
from
573c833 to
6f7db4d
Compare
dinhxuanvu
changed the title
|
I have run the scripts and added the PR #9741 into this one as well. Thanks. |
| } | ||
| "limits": { | ||
| "memory": "${MEMORY_LIMIT}" | ||
| } |
There was a problem hiding this comment.
i just fixed this spacing issue upstream, can you rerun the update script? (sorry)
There was a problem hiding this comment.
(you'll have to rerun the gen bootstrap script as well)
The Python, Ruby, Perl, NodeJS and PHP images have environment variables that allow custom mirror repository URLs to use during the build process to fetch or download required packages instead of the default central repositories. For Python: PIP_INDEX_URL to use custom PyPi mirror link For Perl: CPAN_MIRROR to use custom CPAN mirror link For NodeJS: NPM_MIRROR to use custom NPM mirror link For Ruby: RUBYGEM_MIRROR to use custom RubyGems mirror link For PHP: COMPOSER_MIRROR to use custom Composer/Packagist mirror link This PR modifies templates associated those images to add the parameters to allow users to inject custom mirror links if needed. There are several parameters that are required during the build process. However, those are not marked as required which will cause failure if users leave them blank. Those parameters need to be explicitly marked as required to avoid confusion and unexpected failure. Signed-off-by: Vu Dinh <[email protected]>
|
@bparees Done :) |
|
lgtm |
|
Evaluated for origin test up to 8ac16bb |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/6174/) (Image: devenv-rhel7_4577) |
|
known flake #9681 |
|
Evaluated for origin merge up to 8ac16bb |
The Python, Ruby, Perl, NodeJS and PHP images have environment variables
that allow custom mirror repository URLs to use during the build process
to fetch or download required packages instead of the default central
repositories.
For Python: PIP_INDEX_URL to use custom PyPi mirror link
For Perl: CPAN_MIRROR to use custom CPAN mirror link
For NodeJS: NPM_MIRROR to use custom NPM mirror link
For Ruby: RUBYGEM_MIRROR to use custom RubyGems mirror link
For PHP: COMPOSER_MIRROR to use custom Composer/Packagist mirror link
This PR modifies templates associated those images to add the parameters
to allow users to inject custom mirror links if needed.
There are several parameters that are required during the build process.
However, those are not marked as required which will cause failure if
users leave them blank. Those parameters need to be explicitly marked as
required to avoid confusion and unexpected failure.
Signed-off-by: Vu Dinh [email protected]