add project annotation selectors to cluster quota #9757
Conversation
openshift-bot
added
the
needs-rebase
| // many more less active projects). These projects will contend on object creation through | ||
| // this resource. | ||
| Selector *unversioned.LabelSelector | ||
| Selector ClusterResourceQuotaSelector |
There was a problem hiding this comment.
@smarterclayton We agreed in principle in person. You good with the representation?
deads2k
force-pushed
the
cq-10-annotation-selector
branch
from
01bf6ce to
ea51474
Compare
deads2k
changed the title
|
[test] |
| // LabelSelector is used to select projects by label. | ||
| LabelSelector *unversioned.LabelSelector | ||
|
|
||
| // AnnotationSelector is used to select projects by annotation. |
There was a problem hiding this comment.
Use namespaces consistently in the godoc.
There was a problem hiding this comment.
Use namespaces consistently in the godoc.
switched to project in the docs
|
Yeah it's fine. |
deads2k
force-pushed
the
cq-10-annotation-selector
branch
from
ea51474 to
05bdb14
Compare
|
@Kargakis this updates every layer to handle simple annotation selectors in addition to label selectors so we can restrict by user. |
openshift-bot
removed
the
needs-rebase
| } | ||
| } | ||
|
|
||
| annotationSelector, err := unversioned.ParseToLabelSelector(cmdutil.GetFlagString(cmd, "project-annotation-selector")) |
There was a problem hiding this comment.
Will an empty string create an empty selector?
There was a problem hiding this comment.
Will an empty string create an empty selector?
It will create one with zero MatchLabels in it, which is treated as empty. Empty is allowed as long as the label selector is provided.
There was a problem hiding this comment.
Looked closer at validation. ok
|
Swagger spec needs update |
deads2k
force-pushed
the
cq-10-annotation-selector
branch
from
05bdb14 to
0af555d
Compare
|
lgtm |
deads2k
force-pushed
the
cq-10-annotation-selector
branch
from
0af555d to
19aa546
Compare
|
[merge] |
|
[test] |
deads2k
force-pushed
the
cq-10-annotation-selector
branch
from
19aa546 to
3a44a24
Compare
|
re[test] |
deads2k
force-pushed
the
cq-10-annotation-selector
branch
from
3a44a24 to
3635d26
Compare
|
deployment flakes re[merge] re[test] |
|
Evaluated for origin merge up to 3635d26 |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/6194/) (Image: devenv-rhel7_4580) |
|
deployments re[test] |
|
Evaluated for origin test up to 3635d26 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/6194/) |
This adds an annotation selector (
map[string]string) to theClusterResourceQuotaso that we can select on project requestor username:oc create clusterquota for-deads --project-annotation-selector openshift.io/requester=deads --hard secrets=10This test will be unreliable until quota enforcement merges with #9740
@openshift/api-review The API change is breaking, but no one is using it today
@jwforres @spadgett Breaking API change to
ClusterResourceQuota.Selectorto allow the selection of projects based on annotation selectors.@Kargakis
--project-label-selectorand--project-annotation-selectorfor the create?